Bug 817349 - Ensure topFrame is always defined; r=ted
authorEd Morley <emorley@mozilla.com>
Mon, 03 Dec 2012 14:30:35 +0000
changeset 123886 f19c16aa80f29101273d5642ec94229bb39a64b3
parent 123885 3559bc4dfe1bbbf8a447c7dc39005d62a6e212e1
child 123887 662eaec3b329baebfcd460162e8c0527522c9000
child 123890 7aa3201571ddeb7c6f3bf4b2bf528f4106e30fdf
push id2151
push userlsblakk@mozilla.com
push dateTue, 19 Feb 2013 18:06:57 +0000
treeherdermozilla-beta@4952e88741ec [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted
bugs817349
milestone20.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 817349 - Ensure topFrame is always defined; r=ted
build/automationutils.py
--- a/build/automationutils.py
+++ b/build/automationutils.py
@@ -161,16 +161,17 @@ def checkForCrashes(dumpDir, symbolsPath
     symbolsPath = tempfile.mkdtemp()
     zfile = ZipFileReader(symbolsFile)
     zfile.extractall(symbolsPath)
 
   try:
     for d in dumps:
       stackwalkOutput = []
       stackwalkOutput.append("Crash dump filename: " + d)
+      topFrame = None
       if symbolsPath and stackwalkPath and os.path.exists(stackwalkPath):
         # run minidump stackwalk
         p = subprocess.Popen([stackwalkPath, d, symbolsPath],
                              stdout=subprocess.PIPE,
                              stderr=subprocess.PIPE)
         (out, err) = p.communicate()
         if len(out) > 3:
           # minidump_stackwalk is chatty, so ignore stderr when it succeeds.