Bug 1205038 - Add missing BROWSER_SET_DEFAULT_ALWAYS_CHECK probe to Histograms.json, and fix BROWSER_SET_DEFAULT_TIME_TO_COMPLETION_SECONDS by fixing callback. r=dolske,Gijs, a=sledru
authorJared Wein <jwein@mozilla.com>
Wed, 16 Sep 2015 12:01:03 -0700
changeset 289307 f188a8e5938111813e8b6da06435a235375b2b99
parent 289306 52f2a71f9dd49bcffbdd802ab01de519893274fe
child 289308 c4ed84ecb00475c6264bd7c94314be0afb32a6cc
push id5067
push userraliiev@mozilla.com
push dateMon, 21 Sep 2015 14:04:52 +0000
treeherdermozilla-beta@14221ffe5b2f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdolske, Gijs, sledru
bugs1205038
milestone42.0a2
Bug 1205038 - Add missing BROWSER_SET_DEFAULT_ALWAYS_CHECK probe to Histograms.json, and fix BROWSER_SET_DEFAULT_TIME_TO_COMPLETION_SECONDS by fixing callback. r=dolske,Gijs, a=sledru
browser/components/nsBrowserGlue.js
toolkit/components/telemetry/Histograms.json
--- a/browser/components/nsBrowserGlue.js
+++ b/browser/components/nsBrowserGlue.js
@@ -2774,17 +2774,17 @@ let DefaultBrowserCheck = {
       ShellService.setDefaultBrowser(claimAllTypes, false);
 
       if (this._setAsDefaultTimer) {
         this._setAsDefaultTimer.cancel();
       }
 
       this._setAsDefaultButtonClickStartTime = Math.floor(Date.now() / 1000);
       this._setAsDefaultTimer = Cc["@mozilla.org/timer;1"].createInstance(Ci.nsITimer);
-      this._setAsDefaultTimer.init(function() {
+      this._setAsDefaultTimer.init(() => {
         let isDefault = false;
         let isDefaultError = false;
         try {
           isDefault = ShellService.isDefaultBrowser(true, false);
         } catch (ex) {
           isDefaultError = true;
         }
 
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -7268,16 +7268,22 @@
   "BROWSER_SET_DEFAULT_DIALOG_PROMPT_RAWCOUNT": {
     "expires_in_version": "never",
     "kind": "exponential",
     "high": "250",
     "n_buckets": "15",
     "releaseChannelCollection": "opt-out",
     "description": "The number of times that a profile has seen the 'Set Default Browser' dialog."
   },
+  "BROWSER_SET_DEFAULT_ALWAYS_CHECK": {
+    "expires_in_version": "never",
+    "kind": "boolean",
+    "releaseChannelCollection": "opt-out",
+    "description": "True if the profile has `browser.shell.checkDefaultBrowser` set to true."
+  },
   "BROWSER_SET_DEFAULT_RESULT": {
     "expires_in_version": "never",
     "kind": "enumerated",
     "n_values": "4",
     "releaseChannelCollection": "opt-out",
     "description": "Result of the Set Default Browser dialog (0=Use Firefox + 'Always perform check' unchecked, 1=Use Firefox + 'Always perform check' checked, 2=Not Now + 'Always perform check' unchecked, 3=Not Now + 'Always perform check' checked)"
   },
   "BROWSER_SET_DEFAULT_ERROR": {