Bug 1548240 - Fix browser_rules_inactive_css_(flexbox|grid).js on Beta r=jdescottes
authorMichael Ratcliffe <mratcliffe@mozilla.com>
Mon, 13 May 2019 16:07:00 +0000
changeset 532439 f12becef5ac1fc08696edbabe351707f5e093e3b
parent 532438 c957bff02df08481f0d632033db6578a88a6f6c1
child 532440 f4ab69d7aabffb076527e9768a0a69140dcb631e
push id11268
push usercsabou@mozilla.com
push dateTue, 14 May 2019 15:24:22 +0000
treeherdermozilla-beta@5fb7fcd568d6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjdescottes
bugs1548240
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1548240 - Fix browser_rules_inactive_css_(flexbox|grid).js on Beta r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D30932
devtools/client/inspector/rules/test/browser.ini
devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js
devtools/client/inspector/rules/test/browser_rules_inactive_css_grid.js
--- a/devtools/client/inspector/rules/test/browser.ini
+++ b/devtools/client/inspector/rules/test/browser.ini
@@ -190,19 +190,17 @@ skip-if = (os == "win" && debug) # bug 9
 [browser_rules_grid-toggle_04.js]
 [browser_rules_grid-toggle_05.js]
 [browser_rules_gridline-names-autocomplete.js]
 [browser_rules_guessIndentation.js]
 [browser_rules_highlight-element-rule.js]
 [browser_rules_highlight-property.js]
 [browser_rules_highlight-used-fonts.js]
 [browser_rules_inactive_css_flexbox.js]
-skip-if = true # Bug 1548240
 [browser_rules_inactive_css_grid.js]
-skip-if = true # Bug 1548240
 [browser_rules_inherited-properties_01.js]
 [browser_rules_inherited-properties_02.js]
 [browser_rules_inherited-properties_03.js]
 [browser_rules_inherited-properties_04.js]
 [browser_rules_inline-source-map.js]
 [browser_rules_inline-style-order.js]
 [browser_rules_invalid.js]
 [browser_rules_invalid-source-map.js]
--- a/devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js
+++ b/devtools/client/inspector/rules/test/browser_rules_inactive_css_flexbox.js
@@ -142,16 +142,18 @@ const AFTER = [
         },
         ruleIndex: 1,
       },
     ],
   },
 ];
 
 add_task(async function() {
+  await pushPref("devtools.inspector.inactive.css.enabled", true);
+
   await addTab("data:text/html;charset=utf-8," + encodeURIComponent(TEST_URI));
   const {inspector, view} = await openRuleView();
 
   await runInactiveCSSTests(view, inspector, BEFORE);
 
   // Toggle `display:flex` to disabled.
   await toggleDeclaration(inspector, view, 0, {
     display: "flex",
--- a/devtools/client/inspector/rules/test/browser_rules_inactive_css_grid.js
+++ b/devtools/client/inspector/rules/test/browser_rules_inactive_css_grid.js
@@ -144,16 +144,18 @@ const AFTER = [
         },
         ruleIndex: 1,
       },
     ],
   },
 ];
 
 add_task(async function() {
+  await pushPref("devtools.inspector.inactive.css.enabled", true);
+
   await addTab("data:text/html;charset=utf-8," + encodeURIComponent(TEST_URI));
   const {inspector, view} = await openRuleView();
 
   await runInactiveCSSTests(view, inspector, BEFORE);
 
   // Toggle `display:grid` to disabled.
   await toggleDeclaration(inspector, view, 0, {
     display: "grid",