Bug 1515116 - Remove all useless constructor methods on Fronts. r=jdescottes
authorAlexandre Poirot <poirot.alex@gmail.com>
Thu, 03 Jan 2019 10:09:42 +0000
changeset 509523 f0a67e0b5282cb3052690c09ea39ee7d3456ed0b
parent 509522 1a4647e09ea904c152bbac33dce377a64f9c2286
child 509524 7d4570696c858a5d519ee8554a09160186378625
push id10547
push userffxbld-merge
push dateMon, 21 Jan 2019 13:03:58 +0000
treeherdermozilla-beta@24ec1916bffe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjdescottes
bugs1515116
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1515116 - Remove all useless constructor methods on Fronts. r=jdescottes Depends on D14914 Differential Revision: https://phabricator.services.mozilla.com/D14915
devtools/shared/fronts/actor-registry.js
devtools/shared/fronts/function-call.js
devtools/shared/fronts/node.js
devtools/shared/fronts/string.js
devtools/shared/fronts/webgl.js
--- a/devtools/shared/fronts/actor-registry.js
+++ b/devtools/shared/fronts/actor-registry.js
@@ -6,19 +6,16 @@
 const { components } = require("chrome");
 const Services = require("Services");
 const { actorActorSpec, actorRegistrySpec } = require("devtools/shared/specs/actor-registry");
 const { FrontClassWithSpec, registerFront } = require("devtools/shared/protocol");
 
 loader.lazyImporter(this, "NetUtil", "resource://gre/modules/NetUtil.jsm");
 
 class ActorActorFront extends FrontClassWithSpec(actorActorSpec) {
-  constructor(client, form) {
-    super(client, form);
-  }
 }
 
 exports.ActorActorFront = ActorActorFront;
 registerFront(ActorActorFront);
 
 function request(uri) {
   return new Promise((resolve, reject) => {
     try {
--- a/devtools/shared/fronts/function-call.js
+++ b/devtools/shared/fronts/function-call.js
@@ -5,20 +5,16 @@
 
 const { functionCallSpec } = require("devtools/shared/specs/function-call");
 const { FrontClassWithSpec, registerFront } = require("devtools/shared/protocol");
 
 /**
  * The corresponding Front object for the FunctionCallActor.
  */
 class FunctionCallFront extends FrontClassWithSpec(functionCallSpec) {
-  constructor(client, form) {
-    super(client, form);
-  }
-
   /**
    * Adds some generic information directly to this instance,
    * to avoid extra roundtrips.
    */
   form(form) {
     this.actorID = form.actor;
     this.type = form.type;
     this.name = form.name;
--- a/devtools/shared/fronts/node.js
+++ b/devtools/shared/fronts/node.js
@@ -21,20 +21,16 @@ loader.lazyRequireGetter(this, "nodeCons
   "devtools/shared/dom-node-constants");
 
 const HIDDEN_CLASS = "__fx-devtools-hide-shortcut__";
 
 /**
  * Client side of a node list as returned by querySelectorAll()
  */
 class NodeListFront extends FrontClassWithSpec(nodeListSpec) {
-  constructor(client, form) {
-    super(client, form);
-  }
-
   marshallPool() {
     return this.parent();
   }
 
   // Update the object given a form representation off the wire.
   form(json) {
     this.length = json.length;
   }
--- a/devtools/shared/fronts/string.js
+++ b/devtools/shared/fronts/string.js
@@ -4,20 +4,16 @@
 "use strict";
 
 const {DebuggerServer} = require("devtools/server/main");
 const promise = require("promise");
 const {longStringSpec, SimpleStringFront} = require("devtools/shared/specs/string");
 const { FrontClassWithSpec, registerFront } = require("devtools/shared/protocol");
 
 class LongStringFront extends FrontClassWithSpec(longStringSpec) {
-  constructor(client) {
-    super(client);
-  }
-
   destroy() {
     this.initial = null;
     this.length = null;
     this.strPromise = null;
     super.destroy();
   }
 
   form(form) {
--- a/devtools/shared/fronts/webgl.js
+++ b/devtools/shared/fronts/webgl.js
@@ -9,31 +9,25 @@ const {
   webGLSpec,
 } = require("devtools/shared/specs/webgl");
 const { FrontClassWithSpec, registerFront } = require("devtools/shared/protocol");
 
 /**
  * The corresponding Front object for the ShaderActor.
  */
 class ShaderFront extends FrontClassWithSpec(shaderSpec) {
-  constructor(client, form) {
-    super(client, form);
-  }
 }
 
 exports.ShaderFront = ShaderFront;
 registerFront(ShaderFront);
 
 /**
  * The corresponding Front object for the ProgramActor.
  */
 class ProgramFront extends FrontClassWithSpec(programSpec) {
-  constructor(client, form) {
-    super(client, form);
-  }
 }
 
 exports.ProgramFront = ProgramFront;
 registerFront(ProgramFront);
 
 /**
  * The corresponding Front object for the WebGLActor.
  */