Bug 810470. Part 9: Fix reftests. r=mattwoodrow,a=akeybl
authorRobert O'Callahan <robert@ocallahan.org>
Wed, 14 Nov 2012 22:36:49 -0800
changeset 117012 f0833ab13aef06c38919e289562b108046549fa2
parent 117011 f9cb68fee5c7a09805b08f3cf610b9628e8cfe8a
child 117013 c141f818c5b3d7aad3ad445c39678ca469ac4fd4
push id1708
push userakeybl@mozilla.com
push dateMon, 19 Nov 2012 21:10:21 +0000
treeherdermozilla-beta@27b14fe50103 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmattwoodrow, akeybl
bugs810470, 745025
milestone18.0a2
Bug 810470. Part 9: Fix reftests. r=mattwoodrow,a=akeybl We seem to be invalidating less and some issues with overflowing Cocoa native widget themes have appeared. We've worked around these issues elsewhere, e.g. by getting rid of scrollbars, so I'm doing it here too. The test 745025-1.html dynamically updates a print reftest, which seems to cause problems on Mac with the page shadow drawing. This is not important and is already a known intermittent failure.
layout/reftests/forms/textarea-setvalue-framereconstruction-1.html
layout/reftests/forms/textarea-setvalue-framereconstruction-ref.html
layout/reftests/printing/reftest.list
layout/reftests/scrolling/fixed-opacity-2.html
--- a/layout/reftests/forms/textarea-setvalue-framereconstruction-1.html
+++ b/layout/reftests/forms/textarea-setvalue-framereconstruction-1.html
@@ -24,25 +24,27 @@ function boom()
   var opt1 = document.getElementById("opt1");
   opt1.removeChild(opt1.firstChild);
 
   document.getElementById("textarea").value += " y";
 
   document.getElementById("div").style.MozBinding = "";
   document.documentElement.removeAttribute("class")
 }
+
+window.addEventListener("MozReftestInvalidate", boom, false);
 </script>
 
 </head>
 
-<body onload="setTimeout(boom, 30);">
+<body>
 
 <div id="div">
   <textarea rows="3" cols="5" id="textarea">x</textarea>
 </div>
 
-<select>
+<select style="-moz-appearance:none">
   <option id="opt1">opt1</option>
 </select>
 
 </body>
 </html>
 
--- a/layout/reftests/forms/textarea-setvalue-framereconstruction-ref.html
+++ b/layout/reftests/forms/textarea-setvalue-framereconstruction-ref.html
@@ -3,15 +3,15 @@
 </head>
 
 <body>
 
 <div id="div">
   <textarea rows="3" cols="5" id="textarea">x y</textarea>
 </div>
 
-<select>
+<select style="-moz-appearance:none">
   <option id="opt1"></option>
 </select>
 
 </body>
 </html>
 
--- a/layout/reftests/printing/reftest.list
+++ b/layout/reftests/printing/reftest.list
@@ -16,9 +16,9 @@
 == 626395-1a.html 626395-1-ref.html
 == 626395-1b.html 626395-1-ref.html
 == 626395-2a.html 626395-2-ref.html
 == 626395-2b.html 626395-2-ref.html
 == 626395-2c.html 626395-2-ref.html
 == 626395-2d.html 626395-2-ref.html
 == 652178-1.html 652178-1-ref.html
 == 652178-1.html 652178-1-ref2.html
-== 745025-1.html 745025-1-ref.html
+fuzzy-if(cocoaWidget,1,5000) == 745025-1.html 745025-1-ref.html
--- a/layout/reftests/scrolling/fixed-opacity-2.html
+++ b/layout/reftests/scrolling/fixed-opacity-2.html
@@ -1,11 +1,11 @@
 <!DOCTYPE HTML>
 <html>
-<body style="height:2000px; margin:0;">
+<body style="height:2000px; margin:0; overflow:hidden">
 <div style="height:1000px; background:url(repeatable-diagonal-gradient.png) fixed repeat-x; opacity:0.5"></div>
 <script type="application/javascript">
 var topElements = document.getElementsByClassName("scrollTop");
 if (!topElements.length) {
   topElements = [document.documentElement];
 }
 
 var failed = false;