Bug 1444079 [wpt PR 9924] - Removes lines containing `GLib-GObject-CRITICAL` from the logs, a=testonly
authorkritisingh1 <kritisingh1.ks@gmail.com>
Mon, 09 Apr 2018 16:32:33 +0000
changeset 467009 efe7fae9f43f1c2ad25842b0cdf73ae75eccebba
parent 467008 1e0357b5ad237d0c191f80d5fee6c207d170a4cb
child 467010 eb4bb4149faf48c23a6770f241a706a24f802c52
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1444079
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1444079 [wpt PR 9924] - Removes lines containing `GLib-GObject-CRITICAL` from the logs, a=testonly Automatic update from web-platform-testsremove lines with GLib-GObject-CRITICAL -- minor changes -- minor fixes -- minor changes wpt-commits: d597a463ecff373ab3808d7d0bc3963d040232fa, 36ce60714fc6aa3c57dd16efcef839f779c99a17, a41d0087780cfcfe1381ff73a32cd83bd6d63a38, 284dfe4ed6ac33a4e35b015c44a47dfc8ca3a5c9 wpt-pr: 9924 wpt-commits: d597a463ecff373ab3808d7d0bc3963d040232fa, 36ce60714fc6aa3c57dd16efcef839f779c99a17, a41d0087780cfcfe1381ff73a32cd83bd6d63a38, 284dfe4ed6ac33a4e35b015c44a47dfc8ca3a5c9 wpt-pr: 9924
testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox.py
--- a/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox.py
+++ b/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox.py
@@ -299,22 +299,25 @@ class FirefoxBrowser(Browser):
 
         try:
             return self.runner.process_handler.pid
         except AttributeError:
             return None
 
     def on_output(self, line):
         """Write a line of output from the firefox process to the log"""
-        data = line.decode("utf8", "replace")
-        if self.stack_fixer:
-            data = self.stack_fixer(data)
-        self.logger.process_output(self.pid(),
-                                   data,
-                                   command=" ".join(self.runner.command))
+        if "GLib-GObject-CRITICAL" in line:
+            return
+        if line:
+            data = line.decode("utf8", "replace")
+            if self.stack_fixer:
+                data = self.stack_fixer(data)
+            self.logger.process_output(self.pid(),
+                                      data,
+                                      command=" ".join(self.runner.command))
 
     def is_alive(self):
         if self.runner:
             return self.runner.is_running()
         return False
 
     def cleanup(self):
         self.stop()