Bug 1380133 - Part 10: Whitelist nsStyleContext::PeekStyleXXX for heap writes. r=heycam
authorCameron McCormack <cam@mcc.id.au>
Fri, 21 Jul 2017 11:51:04 +0800
changeset 418838 efc8385a9519befc94228efa961741786ae6b36f
parent 418837 6d725f6b7456f6ea4ef16e49d677372d16ffacda
child 418839 ca627fd1c94b244e0e15a7095a08407311c62b36
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersheycam
bugs1380133
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1380133 - Part 10: Whitelist nsStyleContext::PeekStyleXXX for heap writes. r=heycam MozReview-Commit-ID: BLlJm7JUnOq
js/src/devtools/rootAnalysis/analyzeHeapWrites.js
--- a/js/src/devtools/rootAnalysis/analyzeHeapWrites.js
+++ b/js/src/devtools/rootAnalysis/analyzeHeapWrites.js
@@ -408,16 +408,20 @@ function ignoreContents(entry)
         "Gecko_CSSValue_SetArray",
         "Gecko_CSSValue_InitSharedList",
         "Gecko_EnsureMozBorderColors",
         "Gecko_ClearMozBorderColors",
         "Gecko_AppendMozBorderColors",
         "Gecko_CopyMozBorderColors",
         "Gecko_SetNullImageValue",
 
+        // The analysis thinks we'll write to mBits in the DoGetStyleFoo<false>
+        // call.  Maybe the template parameter confuses it?
+        /nsStyleContext::PeekStyle/,
+
         // Needs main thread assertions or other fixes.
         /UndisplayedMap::GetEntryFor/,
         /nsStyleContext::CalcStyleDifferenceInternal/,
         /EffectCompositor::GetServoAnimationRule/,
         /LookAndFeel::GetColor/,
         "Gecko_CopyStyleContentsFrom",
         "Gecko_CSSValue_SetAbsoluteLength",
         "Gecko_UnsetDirtyStyleAttr",