Bug 1367092 - [flake8] Use per-file-ignores to skip __init__.py files under testing/marionette and testing/firefox-ui, r=ato
authorAndrew Halberstadt <ahalberstadt@mozilla.com>
Fri, 22 Feb 2019 14:37:55 +0000
changeset 518785 ef9a57429d594ef1f75d070784764fc1b70d8595
parent 518784 45bc26c5c749250f733fdc4f77fca660894ba57e
child 518786 ba172b704def575675d1303eef8f0b1c8ca33491
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersato
bugs1367092
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1367092 - [flake8] Use per-file-ignores to skip __init__.py files under testing/marionette and testing/firefox-ui, r=ato This allows us to only skip the "unused import" config in these files rather than the entire thing. This also removes the only two uses of "**" in the exclusion rules which made things a bit simpler for me later on in the series. Differential Revision: https://phabricator.services.mozilla.com/D20493
.flake8
--- a/.flake8
+++ b/.flake8
@@ -13,18 +13,16 @@ exclude =
     js/*.configure,
     gfx/angle/,
     gfx/harfbuzz,
     glx/skia/,
     memory/moz.configure,
     mobile/android/*.configure,
     node_modules,
     security/nss/,
-    testing/firefox-ui/**/__init__.py,
-    testing/marionette/**/__init__.py,
     testing/marionette/harness/marionette_harness/runner/mixins,
     testing/marionette/harness/marionette_harness/tests,
     testing/mochitest/pywebsocket,
     testing/mozharness/configs/test/test_malformed.py,
     tools/lint/test/files,
     tools/infer/test/*.configure,
     tools/crashreporter/*.configure,
 
@@ -36,9 +34,11 @@ ignore =
     F632, F633, F811, E117, W504, W605, W606,
     # These are intentionally disabled (not necessarily for good reason).
     #   F723: syntax error in type comment
     #       text contains quotes which breaks our custom JSON formatter
     F723, E121, E123, E126, E129, E133, E226, E241, E242, E402, E704, E741, W503,
 
 per-file-ignores =
     ipc/ipdl/*: F403, F405
+    testing/firefox-ui/**/__init__.py: F401
+    testing/marionette/**/__init__.py: F401
     testing/mozharness/configs/*: E124, E127, E128, E131, E231, E261, E265, E266, E501, W391