Bug 1549383 - Fix build bustage in CameraParent.cpp. r=jib
☠☠ backed out by 07ec0bc698e3 ☠ ☠
authorPaul Adenot <paul@paul.cx>
Mon, 06 May 2019 20:56:16 +0000
changeset 531593 ef8c4674d0b0f402b5ca674300e239b196b0becd
parent 531592 088d7221c75aa84d4a3ad559e50e1dc99bfd9fa1
child 531594 ea3a73c7788e2b9752d7f00976c8119183e3da18
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjib
bugs1549383
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1549383 - Fix build bustage in CameraParent.cpp. r=jib `rv` is not used anymore out of Nightly, because diagnostic asserts are disabled. Differential Revision: https://phabricator.services.mozilla.com/D30059
dom/media/systemservices/CamerasParent.cpp
--- a/dom/media/systemservices/CamerasParent.cpp
+++ b/dom/media/systemservices/CamerasParent.cpp
@@ -219,17 +219,17 @@ void CamerasParent::StopVideoCapture() {
         }
         nsresult rv = NS_DispatchToMainThread(NewRunnableFrom([self, thread]() {
           if (thread) {
             if (thread->IsRunning()) {
               thread->Stop();
             }
             delete thread;
           }
-          nsresult rv = GetShutdownBarrier()->RemoveBlocker(self);
+          DebugOnly<nsresult> rv = GetShutdownBarrier()->RemoveBlocker(self);
           MOZ_DIAGNOSTIC_ASSERT(NS_SUCCEEDED(rv));
           return NS_OK;
         }));
         if (NS_FAILED(rv)) {
           LOG(("Could not dispatch VideoCaptureThread destruction"));
         }
         return rv;
       }));