Bug 1383395 - Remove an un-needed check for draw background image. r=cjku
authorMichael Scott <michael.scott250+mozilla@gmail.com>
Sun, 23 Jul 2017 12:58:58 +0300
changeset 419371 ef7a9d523ce4442188a9325dcd681ed5f84720ee
parent 419370 4322e8f2e455cfe8c83bad13ca718a38e90bf456
child 419372 614cdfbf0e2c8f8a574f09888ab76872305b3802
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscjku
bugs1383395
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1383395 - Remove an un-needed check for draw background image. r=cjku Remove the the duplicate check for draw background image is false, in the PaintStyleImageLayerWithSC method, as this is already covered by the preceding code. MozReview-Commit-ID: L669Y4OjzE0
layout/painting/nsCSSRendering.cpp
--- a/layout/painting/nsCSSRendering.cpp
+++ b/layout/painting/nsCSSRendering.cpp
@@ -2635,21 +2635,16 @@ nsCSSRendering::PaintStyleImageLayerWith
   }
 
   // The background color is rendered over the entire dirty area,
   // even if the image isn't.
   if (drawBackgroundColor && !isCanvasFrame) {
     DrawBackgroundColor(clipState, &aRenderingCtx, appUnitsPerPixel);
   }
 
-  if (!drawBackgroundImage) {
-    return DrawResult::SUCCESS; // No need to draw layer image, we can early
-                                // return now.
-  }
-
   // Compute the outermost boundary of the area that might be painted.
   // Same coordinate space as aParams.borderArea & aParams.bgClipRect.
   Sides skipSides = aParams.frame->GetSkipSides();
   nsRect paintBorderArea =
     ::BoxDecorationRectForBackground(aParams.frame, aParams.borderArea,
                                      skipSides, &aBorder);
   nsRect clipBorderArea =
     ::BoxDecorationRectForBorder(aParams.frame, aParams.borderArea,