No bug. Remove unused JS_CLASS_MEMBERS argument. r=me.
authorNicholas Nethercote <nnethercote@mozilla.com>
Mon, 06 Jun 2016 09:14:45 +1000
changeset 339574 eeca7b46a4ed8240f5cd94b77e98d7e6a7b36e14
parent 339573 e54065dbe41dc0192f5d1710ad1ba5855f573545
child 339575 fc00bd9f0d0919c7b350862b9b44239a7d5bd837
push id6249
push userjlund@mozilla.com
push dateMon, 01 Aug 2016 13:59:36 +0000
treeherdermozilla-beta@bad9d4f5bf7e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
No bug. Remove unused JS_CLASS_MEMBERS argument. r=me.
js/public/Class.h
--- a/js/public/Class.h
+++ b/js/public/Class.h
@@ -483,17 +483,17 @@ typedef bool
                   ElementAdder* adder);
 
 typedef void
 (* FinalizeOp)(FreeOp* fop, JSObject* obj);
 
 // The special treatment of |finalize| and |trace| is necessary because if we
 // assign either of those hooks to a local variable and then call it -- as is
 // done with the other hooks -- the GC hazard analysis gets confused.
-#define JS_CLASS_MEMBERS(ClassOpsType, FinalizeOpType, FreeOpType) \
+#define JS_CLASS_MEMBERS(ClassOpsType, FreeOpType) \
     const char* name; \
     uint32_t flags; \
     const ClassOpsType* cOps; \
     \
     JSAddPropertyOp    getAddProperty() const { return cOps ? cOps->addProperty : nullptr; } \
     JSDeletePropertyOp getDelProperty() const { return cOps ? cOps->delProperty : nullptr; } \
     JSGetterOp         getGetProperty() const { return cOps ? cOps->getProperty : nullptr; } \
     JSSetterOp         getSetProperty() const { return cOps ? cOps->setProperty : nullptr; } \
@@ -700,17 +700,17 @@ struct JSClassOps
     JSHasInstanceOp     hasInstance;
     JSNative            construct;
     JSTraceOp           trace;
 };
 
 #define JS_NULL_CLASS_OPS nullptr
 
 struct JSClass {
-    JS_CLASS_MEMBERS(JSClassOps, JSFinalizeOp, JSFreeOp);
+    JS_CLASS_MEMBERS(JSClassOps, JSFreeOp);
 
     void* reserved[3];
 };
 
 #define JSCLASS_HAS_PRIVATE             (1<<0)  // objects have private slot
 #define JSCLASS_DELAY_METADATA_BUILDER  (1<<1)  // class's initialization code
                                                 // will call
                                                 // SetNewObjectMetadata itself
@@ -807,17 +807,17 @@ struct JSClass {
 // Initializer for unused members of statically initialized JSClass structs.
 #define JSCLASS_NO_INTERNAL_MEMBERS     {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0}
 #define JSCLASS_NO_OPTIONAL_MEMBERS     0,0,0,0,0,JSCLASS_NO_INTERNAL_MEMBERS
 
 namespace js {
 
 struct Class
 {
-    JS_CLASS_MEMBERS(js::ClassOps, FinalizeOp, FreeOp);
+    JS_CLASS_MEMBERS(js::ClassOps, FreeOp);
     const ClassSpec* spec;
     const ClassExtension* ext;
     const ObjectOps* oOps;
 
     /*
      * Objects of this class aren't native objects. They don't have Shapes that
      * describe their properties and layout. Classes using this flag must
      * provide their own property behavior, either by being proxy classes (do