Bug 1204134 - Disallow warnings in config/moz.build. r=glandium.
☠☠ backed out by 1af6f6b7db1b ☠ ☠
authorNicholas Nethercote <nnethercote@mozilla.com>
Mon, 14 Sep 2015 21:16:33 -0700
changeset 295125 eea9adc2d1a54d8317967ed71e6a45684d278b18
parent 295124 5be65754c0d0a310e5ad22feffce0f79107cca15
child 295126 700d7caf8eaff063ad21b50a15bf8c779259f237
push id5245
push userraliiev@mozilla.com
push dateThu, 29 Oct 2015 11:30:51 +0000
treeherdermozilla-beta@dac831dc1bd0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1204134, 1198334
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1204134 - Disallow warnings in config/moz.build. r=glandium. It was necessary to allow warnings here I introduced ALLOW_COMPILER_WARNINGS in bug 1198334, but something must have changed subsequently because it no longer is necessary.
config/moz.build
--- a/config/moz.build
+++ b/config/moz.build
@@ -38,15 +38,12 @@ PYTHON_UNIT_TESTS += [
     'tests/unit-mozunit.py',
     'tests/unit-nsinstall.py',
     'tests/unit-printprereleasesuffix.py',
 ]
 
 if CONFIG['GNU_CC'] and CONFIG['MOZ_OPTIMIZE']:
     CFLAGS += ['-O3']
 
-# XXX: We should fix these warnings.
-ALLOW_COMPILER_WARNINGS = True
-
 HOST_DEFINES = {
     'UNICODE': True,
     '_UNICODE': True,
 }