Bug 1532186 - Disable readFromParcel_throwOnAlreadyOpen for frequent failures on pgo build. r=gbrown
authorGurzau Raul <rgurzau@mozilla.com>
Fri, 10 May 2019 16:00:06 +0000
changeset 532238 ee952bc0bc518f3976227e25051eb5f1ae70a00d
parent 532237 77a70aed5f5577bddf31845e14453ad4b268bf75
child 532239 f798e09dc294fd2c86f67489ac5b1bbf5195f07d
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgbrown
bugs1532186
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1532186 - Disable readFromParcel_throwOnAlreadyOpen for frequent failures on pgo build. r=gbrown Differential Revision: https://phabricator.services.mozilla.com/D30656
mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/SessionLifecycleTest.kt
--- a/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/SessionLifecycleTest.kt
+++ b/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/SessionLifecycleTest.kt
@@ -96,16 +96,18 @@ class SessionLifecycleTest : BaseSession
         }
 
         sessionRule.session.reload()
         sessionRule.session.waitForPageStop()
     }
 
     @Test(expected = IllegalStateException::class)
     fun readFromParcel_throwOnAlreadyOpen() {
+        //disable readFromParcel_throwOnAlreadyOpen for frequent failures Bug 1532186
+        assumeThat(sessionRule.env.isDebugBuild, equalTo(true))
         // Throw exception if retrying to open again; otherwise we would leak the old open window.
         sessionRule.session.toParcel { parcel ->
             sessionRule.createOpenSession().readFromParcel(parcel)
         }
     }
 
     @Test fun readFromParcel_canLoadPageAfterRead() {
         val newSession = sessionRule.createClosedSession()