Backed out changeset d95016c5fc99 (bug 1351608) because eslint can't find the new plugin "eslint-plugin-no-unsanitized". r=backout
authorSebastian Hengst <archaeopteryx@coole-files.de>
Thu, 29 Jun 2017 01:02:26 +0200
changeset 415372 ed5cc84d317f8c1148eed57f69fd1f91e0eb4cac
parent 415371 36ea00c880db9a3a16e5e9e8441bdf87e3012f81
child 415373 e54513aa792225bdef5d7c0165f1d86ed189bcef
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1351608
milestone56.0a1
backs outd95016c5fc991c075d10b4591491d50650a7c487
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset d95016c5fc99 (bug 1351608) because eslint can't find the new plugin "eslint-plugin-no-unsanitized". r=backout
package.json
tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js
tools/lint/eslint/eslint-plugin-mozilla/package.json
--- a/package.json
+++ b/package.json
@@ -2,18 +2,17 @@
   "name": "mozillaeslintsetup",
   "description": "This package file is for setup of ESLint only for editor integration.",
   "repository": {},
   "license": "MPL-2.0",
   "dependencies": {
     "escope": "^3.6.0",
     "eslint": "3.19.0",
     "eslint-plugin-html": "2.0.3",
-    "eslint-plugin-mozilla": "file:tools/lint/eslint/eslint-plugin-mozilla",
+    "eslint-plugin-mozilla": "file:tools\\lint\\eslint\\eslint-plugin-mozilla",
     "eslint-plugin-react": "6.10.3",
-    "eslint-plugin-spidermonkey-js": "file:tools/lint/eslint/eslint-plugin-spidermonkey-js",
-    "eslint-plugin-no-unsanitized": "2.0.1",
+    "eslint-plugin-spidermonkey-js": "file:tools\\lint\\eslint\\eslint-plugin-spidermonkey-js",
     "espree": "^3.4.0",
     "estraverse": "^4.2.0",
     "ini-parser": "^0.0.2",
     "sax": "^1.2.2"
   }
 }
--- a/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js
+++ b/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js
@@ -58,18 +58,17 @@ module.exports = {
   },
 
   "parserOptions": {
     "ecmaVersion": 8
   },
 
   // When adding items to this file please check for effects on sub-directories.
   "plugins": [
-    "mozilla",
-    "no-unsanitized"
+    "mozilla"
   ],
 
   // When adding items to this file please check for effects on all of toolkit
   // and browser
   "rules": {
     // Require spacing around =>
     "arrow-spacing": "error",
 
@@ -295,21 +294,16 @@ module.exports = {
     "no-unreachable": "error",
 
     // Disallow control flow statements in finally blocks
     "no-unsafe-finally": "error",
 
     // No (!foo in bar) or (!object instanceof Class)
     "no-unsafe-negation": "error",
 
-    // No unsanitized use of innerHTML=, document.write() etc.
-    // cf. https://github.com/mozilla/eslint-plugin-no-unsanitized#rule-details
-    "no-unsanitized/method": "error",
-    "no-unsanitized/property": "error",
-
     // No declaring variables that are never used
     "no-unused-vars": ["error", {
       "args": "none",
       "vars": "local",
       "varsIgnorePattern": "^Cc|Ci|Cu|Cr|EXPORTED_SYMBOLS"
     }],
 
     // No using variables before defined
--- a/tools/lint/eslint/eslint-plugin-mozilla/package.json
+++ b/tools/lint/eslint/eslint-plugin-mozilla/package.json
@@ -16,17 +16,16 @@
   "repository": {
     "type": "hg",
     "url": "https://hg.mozilla.org/mozilla-central/"
   },
   "author": "Mike Ratcliffe",
   "main": "lib/index.js",
   "dependencies": {
     "escope": "^3.6.0",
-    "eslint-plugin-no-unsanitized": "^2.0.1",
     "espree": "^3.4.0",
     "estraverse": "^4.2.0",
     "globals": "^9.14.0",
     "ini-parser": "^0.0.2",
     "sax": "^1.2.2"
   },
   "devDependencies": {
     "mocha": "3.2.0"