Bug 834768: Fix signed/unsigned comparison build warnings in signaling_unittests.cpp. r=jesup
authorDaniel Holbert <dholbert@cs.stanford.edu>
Tue, 29 Jan 2013 20:03:42 -0800
changeset 130199 ec05a370f01d46722b1589d55223dd44d3eccb07
parent 130198 8ef47aa7120f2202fc80c9004d7fcab95ef3c9a3
child 130200 aaa82cd26aabee668537dedfd958d2962165eea5
push id2323
push userbbajaj@mozilla.com
push dateMon, 01 Apr 2013 19:47:02 +0000
treeherdermozilla-beta@7712be144d91 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjesup
bugs834768
milestone21.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 834768: Fix signed/unsigned comparison build warnings in signaling_unittests.cpp. r=jesup
media/webrtc/signaling/test/signaling_unittests.cpp
--- a/media/webrtc/signaling/test/signaling_unittests.cpp
+++ b/media/webrtc/signaling/test/signaling_unittests.cpp
@@ -462,17 +462,17 @@ class ParsedSDP {
       } else {
         value = (*it).first + ' ' + sdp_line_pair.second;
         sdp_lines[sdp_line_pair.first] = value;
       }
    }
 
     //generate our final sdp in string format
     std::string sdp;
-    for(int i=0; i < sdp_lines.size(); i++)
+    for (size_t i = 0; i < sdp_lines.size(); i++)
     {
       sdp += sdp_lines[i];
     }
 
     return sdp;
   }
 
 
@@ -755,17 +755,17 @@ void CreateAnswer(sipcc::MediaConstraint
         domMediaStream_->GetStream())->StopStream();
   }
 
   //Stops pulling audio data off the receivers.
   //Should be called before Cleanup of the peer connection.
   void CloseReceiveStreams() {
     std::vector<nsDOMMediaStream *> streams =
                             pObserver->GetStreams();
-    for(int i=0; i < streams.size(); i++) {
+    for (size_t i = 0; i < streams.size(); i++) {
       streams[i]->GetStream()->AsSourceStream()->StopStream();
     }
   }
 
 public:
   mozilla::RefPtr<sipcc::PeerConnectionImpl> pc;
   nsRefPtr<TestObserver> pObserver;
   char* offer_;