Bug 1547614 View History Sidebar menu is missing label for in Library toolbutton r=jaws
authorMohd Umar Alam <umaralam48@gmail.com>
Tue, 30 Apr 2019 13:04:47 +0000
changeset 530740 eb532b01e59209fdbd14b37baa2ab65317bd3e0a
parent 530739 44829dfb74d2147e9c2cb0b45dacad650bfe4782
child 530741 f5e9c49cc66d70714077c772900a71fad0d837ff
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1547614
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1547614 View History Sidebar menu is missing label for in Library toolbutton r=jaws Differential Revision: https://phabricator.services.mozilla.com/D29133
browser/components/customizableui/content/panelUI.inc.xul
--- a/browser/components/customizableui/content/panelUI.inc.xul
+++ b/browser/components/customizableui/content/panelUI.inc.xul
@@ -398,16 +398,17 @@
                        key="key_quitApplication"
                        command="cmd_quitApplication"/>
 #endif
       </vbox>
     </panelview>
     <panelview id="PanelUI-history" flex="1">
       <vbox class="panel-subview-body">
         <toolbarbutton id="appMenuViewHistorySidebar"
+                       label="&appMenuHistory.viewSidebar.label;"
                        label-checked="&appMenuHistory.hideSidebar.label;"
                        label-unchecked="&appMenuHistory.viewSidebar.label;"                      
                        type="checkbox"
                        class="subviewbutton subviewbutton-iconic"
                        key="key_gotoHistory"
                        oncommand="SidebarUI.toggle('viewHistorySidebar');">
                        <observes element="sidebar-box" attribute="positionend"/>
         </toolbarbutton>
@@ -450,16 +451,17 @@
                descriptionheightworkaround="true">
       <vbox class="panel-subview-body">
         <!-- this widget has 3 boxes in the body, but only 1 is ever visible -->
         <!-- When Sync is ready to sync -->
         <vbox id="PanelUI-remotetabs-main" hidden="true">
           <vbox id="PanelUI-remotetabs-buttons">
             <toolbarbutton id="PanelUI-remotetabs-view-sidebar"
                            class="subviewbutton subviewbutton-iconic"
+                           label="&appMenuRemoteTabs.sidebar.label;"
                            label-checked="&appMenuRemoteTabs.hidesidebar.label;"
                            label-unchecked="&appMenuRemoteTabs.sidebar.label;"
                            oncommand="SidebarUI.toggle('viewTabsSidebar', this);"/>
             <toolbarbutton id="PanelUI-remotetabs-view-managedevices"
                            class="subviewbutton subviewbutton-iconic"
                            label="&appMenuRemoteTabs.managedevices.label;"
                            oncommand="gSync.openDevicesManagementPage('syncedtabs-menupanel');">
                            <observes element="sidebar-box" attribute="positionend"/>