Bug 1516025 part 2: Add needed #includes to some files in dom/svg to preemptively fix unified build bustage. r=longsonr
authorDaniel Holbert <dholbert@cs.stanford.edu>
Fri, 21 Dec 2018 23:29:24 +0000
changeset 508930 eab4ecad469f58b7b57ff696155ef4320c668eb9
parent 508929 780ab4fd468b92f567c7198f6ba91e83a60388de
child 508931 8fd83a79a594383e7a3bdf9c7c74a9262e97ee9a
push id10547
push userffxbld-merge
push dateMon, 21 Jan 2019 13:03:58 +0000
treeherdermozilla-beta@24ec1916bffe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslongsonr
bugs1516025
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1516025 part 2: Add needed #includes to some files in dom/svg to preemptively fix unified build bustage. r=longsonr And while I'm here, I'm giving SVGDataParser.h a more specific/efficient string include, to just provide the *forward-decl* of nsAString for this file's "nsAString&" usage in a function prototype. Depends on D15231 Differential Revision: https://phabricator.services.mozilla.com/D15232
dom/svg/SVGDataParser.h
dom/svg/SVGElementFactory.h
dom/svg/SVGMarkerElement.cpp
dom/svg/SVGSVGElement.cpp
dom/svg/SVGStringList.cpp
dom/svg/SVGTests.cpp
--- a/dom/svg/SVGDataParser.h
+++ b/dom/svg/SVGDataParser.h
@@ -2,18 +2,19 @@
 /* vim: set ts=8 sts=2 et sw=2 tw=80: */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #ifndef __NS_SVGDATAPARSER_H__
 #define __NS_SVGDATAPARSER_H__
 
+#include <cctype>
 #include "mozilla/RangedPtr.h"
-#include "nsString.h"
+#include "nsStringFwd.h"
 
 namespace mozilla {
 
 ////////////////////////////////////////////////////////////////////////
 // SVGDataParser: a simple base class for parsing values
 // for path and transform values.
 //
 class SVGDataParser {
--- a/dom/svg/SVGElementFactory.h
+++ b/dom/svg/SVGElementFactory.h
@@ -2,17 +2,23 @@
 /* vim: set ts=8 sts=2 et sw=2 tw=80: */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #ifndef mozilla_dom_SVGElementFactory_h
 #define mozilla_dom_SVGElementFactory_h
 
+#include "nsError.h"
+#include "mozilla/AlreadyAddRefed.h"
+#include "mozilla/dom/FromParser.h"
+#include "mozilla/dom/NodeInfo.h"
+
 class nsAtom;
+class nsIContent;
 
 namespace mozilla {
 namespace dom {
 
 class SVGElementFactory {
  public:
   static void Init();
   static void Shutdown();
--- a/dom/svg/SVGMarkerElement.cpp
+++ b/dom/svg/SVGMarkerElement.cpp
@@ -6,16 +6,17 @@
 
 #include "mozilla/ArrayUtils.h"
 
 #include "nsGkAtoms.h"
 #include "nsCOMPtr.h"
 #include "SVGAnimatedPreserveAspectRatio.h"
 #include "nsError.h"
 #include "mozilla/dom/SVGAngle.h"
+#include "mozilla/dom/SVGGeometryElement.h"
 #include "mozilla/dom/SVGLengthBinding.h"
 #include "mozilla/dom/SVGMarkerElement.h"
 #include "mozilla/dom/SVGMarkerElementBinding.h"
 #include "mozilla/gfx/Matrix.h"
 #include "mozilla/FloatingPoint.h"
 #include "SVGContentUtils.h"
 
 using namespace mozilla::gfx;
--- a/dom/svg/SVGSVGElement.cpp
+++ b/dom/svg/SVGSVGElement.cpp
@@ -3,16 +3,17 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "mozilla/ContentEvents.h"
 #include "mozilla/dom/SVGSVGElement.h"
 #include "mozilla/dom/SVGSVGElementBinding.h"
 #include "mozilla/dom/SVGMatrix.h"
+#include "mozilla/dom/SVGRect.h"
 #include "mozilla/dom/SVGViewElement.h"
 #include "mozilla/EventDispatcher.h"
 
 #include "DOMSVGLength.h"
 #include "DOMSVGNumber.h"
 #include "DOMSVGPoint.h"
 #include "nsLayoutStylesheetCache.h"
 #include "nsSVGAngle.h"
--- a/dom/svg/SVGStringList.cpp
+++ b/dom/svg/SVGStringList.cpp
@@ -2,16 +2,17 @@
 /* vim: set ts=8 sts=2 et sw=2 tw=80: */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "SVGStringList.h"
 #include "nsError.h"
 #include "nsCharSeparatedTokenizer.h"
+#include "nsContentUtils.h"
 #include "nsString.h"
 #include "nsWhitespaceTokenizer.h"
 #include "SVGContentUtils.h"
 
 namespace mozilla {
 
 nsresult SVGStringList::CopyFrom(const SVGStringList& rhs) {
   if (!mStrings.Assign(rhs.mStrings, fallible)) {
--- a/dom/svg/SVGTests.cpp
+++ b/dom/svg/SVGTests.cpp
@@ -1,16 +1,18 @@
 /* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
 /* vim: set ts=8 sts=2 et sw=2 tw=80: */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "mozilla/dom/SVGTests.h"
 #include "DOMSVGStringList.h"
+#include "nsIContent.h"
+#include "nsIContentInlines.h"
 #include "nsSVGFeatures.h"
 #include "mozilla/dom/SVGSwitchElement.h"
 #include "nsCharSeparatedTokenizer.h"
 #include "nsStyleUtil.h"
 #include "mozilla/Preferences.h"
 
 namespace mozilla {
 namespace dom {