Backed out changeset a9b90a979fc7 (bug 1508382) for Linting failure. CLOSED TREE
authorDorel Luca <dluca@mozilla.com>
Mon, 26 Nov 2018 21:01:27 +0200
changeset 504519 ea9af5fdb20e64d55b0ff4ff748ca35f949f0353
parent 504518 2d4d18da8dc3114f66eb405d7f1aa937464128a7
child 504520 480ef6d926d5b5bb65b8300e7a9482a1598e314e
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1508382
milestone65.0a1
backs outa9b90a979fc70966dde072d66d97bde8e69066bb
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset a9b90a979fc7 (bug 1508382) for Linting failure. CLOSED TREE
taskcluster/taskgraph/transforms/job/toolchain.py
taskcluster/taskgraph/transforms/task.py
--- a/taskcluster/taskgraph/transforms/job/toolchain.py
+++ b/taskcluster/taskgraph/transforms/job/toolchain.py
@@ -156,18 +156,18 @@ def docker_worker_toolchain(config, job,
         wrapper = ''
 
     args = run.get('arguments', '')
     if args:
         args = ' ' + shell_quote(*args)
 
     sparse_profile = []
     if run.get('sparse-profile'):
-        sparse_profile = ['--sparse-profile=build/sparse-profiles/{}'
-                          .format(run['sparse-profile'])]
+        sparse_profile = ['--sparse-profile',
+                          'build/sparse-profiles/{}'.format(run['sparse-profile'])]
 
     worker['command'] = [
         '{workdir}/bin/run-task'.format(**run),
         '--vcs-checkout={}'.format(gecko_path),
     ] + sparse_profile + [
         '--',
         'bash',
         '-c',
--- a/taskcluster/taskgraph/transforms/task.py
+++ b/taskcluster/taskgraph/transforms/task.py
@@ -1909,25 +1909,16 @@ def check_run_task_caches(config, tasks)
             for arg in command[1:]:
                 if not isinstance(arg, basestring):
                     continue
 
                 if arg == '--':
                     break
 
                 if arg.startswith('--sparse-profile'):
-                    if '=' not in arg:
-                        raise Exception(
-                            '{} is specifying `--sparse-profile` to run-task as two arguments. '
-                            'Unable to determine if the sparse profile exists.'.format(task['label']))
-                    _, sparse_profile = arg.split('=', 1)
-                    if not os.path.exists(os.path.join(GECKO, sparse_profile)):
-                        raise Exception(
-                            '{} is using non-existant sparse profile {}.'.format(
-                                task['label'], sparse_profile))
                     require_sparse_cache = True
                     break
 
         for cache in payload.get('cache', {}):
             if re_sparse_checkout_cache.match(cache):
                 have_sparse_cache = True
 
             if not re_reserved_caches.match(cache):