Bug 1446391 [wpt PR 10075] - Add memory of last SDP offer/answer created, a=testonly
authorHarald Alvestrand <hta@chromium.org>
Mon, 09 Apr 2018 17:39:05 +0000
changeset 467157 ea2668153d4af4aee66e628882b26a5387c02e3c
parent 467156 05184c40e4d5cbf2d895e8f534a4293b342de242
child 467158 8100de6989ad49533de211d3a325d7e05323fdb6
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1446391, 10075, 823036, 966441, 545175
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1446391 [wpt PR 10075] - Add memory of last SDP offer/answer created, a=testonly Automatic update from web-platform-testsAdd memory of last SDP offer/answer created This adds internal slots "LastOffer" and "LastAnswer", and uses those to check that SetLocalDescription uses an unchanged SDP offer/answer. Because modification of SDP is suspected to be used in a number of places, this change only rejects SDP with modified fingerprints (which would fail anyway), but merely counts the usage for other modifications. Bug: chromium:823036 Change-Id: I0c978d5ff3e63b0afab3ec02334c57a5aaa94cdd Reviewed-on: https://chromium-review.googlesource.com/966441 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545175} wpt-commits: e48a42ff61e97e4b6fbae0f66be03d60e20b9400 wpt-pr: 10075 wpt-commits: e48a42ff61e97e4b6fbae0f66be03d60e20b9400 wpt-pr: 10075
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -603508,17 +603508,17 @@
    "aab677c9196488544b30c7eecd180c3046290bb2",
    "testharness"
   ],
   "webrtc/RTCPeerConnection-setLocalDescription-answer.html": [
    "e215aa042c67a23ae776b83d662a035a22e03810",
    "testharness"
   ],
   "webrtc/RTCPeerConnection-setLocalDescription-offer.html": [
-   "9f30ee4801fbcd574d90c3f15a733c448f148649",
+   "117fc91599d11b63f2d232a63bace8e367dbb72a",
    "testharness"
   ],
   "webrtc/RTCPeerConnection-setLocalDescription-pranswer.html": [
    "9653d2176c51b638b0c03dec363d2a2fb8386281",
    "testharness"
   ],
   "webrtc/RTCPeerConnection-setLocalDescription-rollback.html": [
    "293081a9ebd031cc4919a01ec323630394d401a8",
--- a/testing/web-platform/tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html
+++ b/testing/web-platform/tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html
@@ -94,21 +94,22 @@
     4.3.2.  setLocalDescription
       2.  Let lastOffer be the result returned by the last call to createOffer.
       6.  If description.type is offer and description.sdp does not match lastOffer,
           reject the promise with a newly created InvalidModificationError and abort
           these steps.
    */
   promise_test(t => {
     const pc = new RTCPeerConnection();
+    const pc2 = new RTCPeerConnection();
 
     return generateOffer({ pc, data: true })
     .then(offer =>
       promise_rejects(t, 'InvalidModificationError',
-        pc.setLocalDescription(offer)));
+        pc2.setLocalDescription(offer)));
   }, 'setLocalDescription() with offer not created by own createOffer() should reject with InvalidModificationError');
 
   promise_test(t => {
     // Create first offer with audio line, then second offer with
     // both audio and video line. Since the second offer is the
     // last offer, setLocalDescription would reject when setting
     // with the first offer
     const pc = new RTCPeerConnection();