Bug 1549667 - [mips64] Adding missing 'breaks' to 'switch' statements. r=jandem
authorYu Yin <yuyin-hf@loongson.cn>
Fri, 10 May 2019 10:01:37 +0300
changeset 532173 e8aa696bdf817cf7b01be648d47f280ab54f8382
parent 532172 9321de8191813e81fcfd2a9c02d1faa90cebdaa5
child 532174 3c7878ad3840fbf8c2aee6df01f24e8e650f5fc3
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjandem
bugs1549667
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1549667 - [mips64] Adding missing 'breaks' to 'switch' statements. r=jandem Reviewers: jandem Reviewed By: jandem Subscribers: jandem Bug #: 1549667 Differential Revision: https://phabricator.services.mozilla.com/D30167
js/src/jit/mips64/CodeGenerator-mips64.cpp
--- a/js/src/jit/mips64/CodeGenerator-mips64.cpp
+++ b/js/src/jit/mips64/CodeGenerator-mips64.cpp
@@ -75,16 +75,17 @@ void CodeGenerator::visitUnbox(LUnbox* u
       case MIRType::String:
         masm.unboxString(inputReg, result);
         break;
       case MIRType::Symbol:
         masm.unboxSymbol(inputReg, result);
         break;
       case MIRType::BigInt:
         masm.unboxBigInt(inputReg, result);
+        break;
       default:
         MOZ_CRASH("Given MIRType cannot be unboxed.");
     }
     return;
   }
 
   Address inputAddr = ToAddress(input);
   switch (mir->type()) {
@@ -100,16 +101,17 @@ void CodeGenerator::visitUnbox(LUnbox* u
     case MIRType::String:
       masm.unboxString(inputAddr, result);
       break;
     case MIRType::Symbol:
       masm.unboxSymbol(inputAddr, result);
       break;
     case MIRType::BigInt:
       masm.unboxBigInt(inputAddr, result);
+      break;
     default:
       MOZ_CRASH("Given MIRType cannot be unboxed.");
   }
 }
 
 void CodeGeneratorMIPS64::splitTagForTest(const ValueOperand& value,
                                           ScratchTagScope& tag) {
   masm.splitTag(value.valueReg(), tag);