Bug 1456192 - make Pickle::ReadSentinel MOZ_NEVER_INLINE; r=froydnj
authorDavid Major <dmajor@mozilla.com>
Mon, 23 Apr 2018 14:13:37 -0400
changeset 468677 e893040e197fc005256d3f07ac3ba53ad5da3d28
parent 468676 45ba3fb2d9ccf3cadf6f5b77808bdf9e25a7e415
child 468678 5f5f5d37a32ebc395b4e65c442763a18089b95f0
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1456192
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1456192 - make Pickle::ReadSentinel MOZ_NEVER_INLINE; r=froydnj This function is just pure bloat when it gets inlined, and it will disappear on non-Nightly builds anyway. Make it MOZ_NEVER_INLINE so our size statistics on Nightly are somewhat more reflective of our size statistics on Release.
ipc/chromium/src/base/pickle.cc
--- a/ipc/chromium/src/base/pickle.cc
+++ b/ipc/chromium/src/base/pickle.cc
@@ -446,16 +446,17 @@ bool Pickle::ReadBytesInto(PickleIterato
   if (!buffers_.ReadBytes(iter->iter_, reinterpret_cast<char*>(data), length)) {
     return false;
   }
 
   return iter->iter_.AdvanceAcrossSegments(buffers_, AlignInt(length) - length);
 }
 
 #ifdef MOZ_PICKLE_SENTINEL_CHECKING
+MOZ_NEVER_INLINE
 bool Pickle::ReadSentinel(PickleIterator* iter, uint32_t sentinel) const {
   uint32_t found;
   if (!ReadUInt32(iter, &found)) {
     return false;
   }
   return found == sentinel;
 }