Backed out changeset 2ac5c1345f13 (bug 1399217) for eslint failure at devtools/client/sourceeditor/editor.js:554: Strings must use doublequote. r=backout
authorSebastian Hengst <archaeopteryx@coole-files.de>
Wed, 13 Sep 2017 15:01:25 +0200
changeset 430049 e8744e2681065da8a77f08d570509669baa8bb82
parent 430048 a7367247baa45a50f0082682f087c71b2d2e771f
child 430050 3bc5e761010106e02ec3267224f905c461508c7b
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1399217
milestone57.0a1
backs out2ac5c1345f1353b685a8e18abe31134e0c0712cf
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 2ac5c1345f13 (bug 1399217) for eslint failure at devtools/client/sourceeditor/editor.js:554: Strings must use doublequote. r=backout
devtools/client/sourceeditor/editor.js
--- a/devtools/client/sourceeditor/editor.js
+++ b/devtools/client/sourceeditor/editor.js
@@ -546,17 +546,17 @@ Editor.prototype = {
 
   /**
    * Replaces whatever is in the text area with the contents of
    * the 'value' argument.
    */
   setText: function (value) {
     let cm = editors.get(this);
 
-    if (typeof value !== "string" && 'binary' in value) {  // wasm?
+    if (typeof value !== "string") {  // wasm?
       // binary does not survive as Uint8Array, converting from string
       let binary = value.binary;
       let data = new Uint8Array(binary.length);
       for (let i = 0; i < data.length; i++) {
         data[i] = binary.charCodeAt(i);
       }
       let { lines, done } = getWasmText(this.getDoc(), data);
       const MAX_LINES = 10000000;