Bug 1483575 - Update font editor in response to font property value changes outside the selected rule. r=gl
authorRazvan Caliman <rcaliman@mozilla.com>
Thu, 16 Aug 2018 14:26:48 +0000
changeset 487206 e85a0366a59931baecbf1333ec8e5d83e64d5659
parent 487205 acbbc15249bf3fcb645ac5d685a7e0fdccd9cae2
child 487207 4105f56578d414b83e302fe5f835824f1b6f3aac
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgl
bugs1483575
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1483575 - Update font editor in response to font property value changes outside the selected rule. r=gl Differential Revision: https://phabricator.services.mozilla.com/D3502
devtools/client/inspector/fonts/fonts.js
--- a/devtools/client/inspector/fonts/fonts.js
+++ b/devtools/client/inspector/fonts/fonts.js
@@ -810,19 +810,17 @@ class FontInspector {
    * Handler for "property-value-updated" event emitted from the rule view whenever a
    * property value changes. Ignore changes to properties unrelated to the font editor.
    *
    * @param {Object} eventData
    *        Object with the property name and value and origin rule.
    *        Example: { name: "font-size", value: "1em", rule: Object }
    */
   async onRulePropertyUpdated(eventData) {
-    if (!this.selectedRule ||
-        !this.selectedRule.matches({ rule: eventData.rule.domRule }) ||
-        !FONT_PROPERTIES.includes(eventData.property)) {
+    if (!this.selectedRule || !FONT_PROPERTIES.includes(eventData.property)) {
       return;
     }
 
     if (this.isPanelVisible()) {
       await this.refreshFontEditor();
     }
   }