Bug 1507945 - ReadableStreamDefaultController.length and ReadableByteStreamController.length should be 0. r=jwalden
authorJason Orendorff <jorendorff@mozilla.com>
Thu, 22 Nov 2018 17:36:12 +0000
changeset 504213 e838d2083baf3ce8143cc89046aa9c4cbbf72d42
parent 504212 c4de0c7b78ed1740c8072e7509230b4bd5352261
child 504214 ac1c8b26e69085a1ce075939533eb081b9e997ce
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjwalden
bugs1507945
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1507945 - ReadableStreamDefaultController.length and ReadableByteStreamController.length should be 0. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D12323
js/src/builtin/Stream.cpp
testing/web-platform/meta/streams/readable-streams/general.dedicatedworker.html.ini
testing/web-platform/meta/streams/readable-streams/general.html.ini
testing/web-platform/meta/streams/readable-streams/general.serviceworker.https.html.ini
testing/web-platform/meta/streams/readable-streams/general.sharedworker.html.ini
--- a/js/src/builtin/Stream.cpp
+++ b/js/src/builtin/Stream.cpp
@@ -2515,17 +2515,17 @@ static const JSFunctionSpec ReadableStre
     JS_FN("error",      ReadableStreamDefaultController_error,      1, 0),
     JS_FS_END
 };
 
 const Class ReadableStreamController::class_ = {
     "ReadableStreamController"
 };
 
-CLASS_SPEC(ReadableStreamDefaultController, 4, SlotCount, ClassSpec::DontDefineConstructor, 0,
+CLASS_SPEC(ReadableStreamDefaultController, 0, SlotCount, ClassSpec::DontDefineConstructor, 0,
            JS_NULL_CLASS_OPS);
 
 /**
  * Unified implementation of ReadableStream controllers' [[CancelSteps]]
  * internal methods.
  * Streams spec, 3.8.5.1. [[CancelSteps]] ( reason )
  * and
  * Streams spec, 3.10.5.1. [[CancelSteps]] ( reason )
@@ -3449,17 +3449,17 @@ static const ClassOps ReadableByteStream
     nullptr,        /* mayResolve */
     ReadableByteStreamControllerFinalize,
     nullptr,        /* call        */
     nullptr,        /* hasInstance */
     nullptr,        /* construct   */
     nullptr,        /* trace   */
 };
 
-CLASS_SPEC(ReadableByteStreamController, 3, SlotCount, ClassSpec::DontDefineConstructor,
+CLASS_SPEC(ReadableByteStreamController, 0, SlotCount, ClassSpec::DontDefineConstructor,
            JSCLASS_BACKGROUND_FINALIZE, &ReadableByteStreamControllerClassOps);
 
 // Streams spec, 3.10.5.1. [[CancelSteps]] ()
 // Unified with 3.8.5.1 above.
 
 static MOZ_MUST_USE bool
 ReadableByteStreamControllerHandleQueueDrain(JSContext* cx,
                                              Handle<ReadableStreamController*> unwrappedController);
--- a/testing/web-platform/meta/streams/readable-streams/general.dedicatedworker.html.ini
+++ b/testing/web-platform/meta/streams/readable-streams/general.dedicatedworker.html.ini
@@ -3,11 +3,8 @@
     expected: FAIL
 
   [ReadableStream constructor will not tolerate initial garbage as cancel argument]
     expected: FAIL
 
   [ReadableStream constructor will not tolerate initial garbage as pull argument]
     expected: FAIL
 
-  [ReadableStream start should be called with the proper parameters]
-    expected: FAIL
-
--- a/testing/web-platform/meta/streams/readable-streams/general.html.ini
+++ b/testing/web-platform/meta/streams/readable-streams/general.html.ini
@@ -3,11 +3,8 @@
     expected: FAIL
 
   [ReadableStream constructor will not tolerate initial garbage as cancel argument]
     expected: FAIL
 
   [ReadableStream constructor will not tolerate initial garbage as pull argument]
     expected: FAIL
 
-  [ReadableStream start should be called with the proper parameters]
-    expected: FAIL
-
--- a/testing/web-platform/meta/streams/readable-streams/general.serviceworker.https.html.ini
+++ b/testing/web-platform/meta/streams/readable-streams/general.serviceworker.https.html.ini
@@ -3,11 +3,8 @@
     expected: FAIL
 
   [ReadableStream constructor will not tolerate initial garbage as cancel argument]
     expected: FAIL
 
   [ReadableStream constructor will not tolerate initial garbage as pull argument]
     expected: FAIL
 
-  [ReadableStream start should be called with the proper parameters]
-    expected: FAIL
-
--- a/testing/web-platform/meta/streams/readable-streams/general.sharedworker.html.ini
+++ b/testing/web-platform/meta/streams/readable-streams/general.sharedworker.html.ini
@@ -3,11 +3,8 @@
     expected: FAIL
 
   [ReadableStream constructor will not tolerate initial garbage as cancel argument]
     expected: FAIL
 
   [ReadableStream constructor will not tolerate initial garbage as pull argument]
     expected: FAIL
 
-  [ReadableStream start should be called with the proper parameters]
-    expected: FAIL
-