Bug 1286092 - Do repackage-signing on-change for on-change l10n. r=aki
authorJustin Wood <Callek@gmail.com>
Tue, 22 May 2018 09:42:19 -0400
changeset 474741 e73477aafd06d02e1e8ad17fbddba329beb6e996
parent 474740 a562a809e8dc82d5ab315f5ebdcc316b214e50cc
child 474742 8a9c609fa789377511574c2bd3a075335c63543e
push id9374
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:43:20 +0000
treeherdermozilla-beta@160e085dfb0b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaki
bugs1286092
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1286092 - Do repackage-signing on-change for on-change l10n. r=aki for L10n jobs should run per-push based on the corresponding builds Differential Revision: https://phabricator.services.mozilla.com/D1408
taskcluster/ci/repackage-signing/kind.yml
taskcluster/taskgraph/transforms/repackage_signing.py
--- a/taskcluster/ci/repackage-signing/kind.yml
+++ b/taskcluster/ci/repackage-signing/kind.yml
@@ -19,10 +19,12 @@ only-for-build-platforms:
    - linux-devedition-nightly/opt
    - linux64-nightly/opt
    - linux64-devedition-nightly/opt
    - linux64-asan-reporter-nightly/opt
    - macosx64-nightly/opt
    - macosx64-devedition-nightly/opt
    - win32-nightly/opt
    - win32-devedition-nightly/opt
+   - win32/opt
    - win64-nightly/opt
    - win64-devedition-nightly/opt
+   - win64/opt
--- a/taskcluster/taskgraph/transforms/repackage_signing.py
+++ b/taskcluster/taskgraph/transforms/repackage_signing.py
@@ -44,53 +44,56 @@ def validate(config, jobs):
             "In repackage-signing ({!r} kind) task for {!r}:".format(config.kind, label))
         yield job
 
 
 @transforms.add
 def make_repackage_signing_description(config, jobs):
     for job in jobs:
         dep_job = job['dependent-task']
-        attributes = dep_job.attributes
+        attributes = copy_attributes_from_dependent_job(dep_job)
+        attributes['repackage_type'] = 'repackage-signing'
 
         treeherder = job.get('treeherder', {})
-        treeherder.setdefault('symbol', 'rs(N)')
+        if attributes.get('nightly'):
+            treeherder.setdefault('symbol', 'rs(N)')
+        else:
+            treeherder.setdefault('symbol', 'rs(B)')
         dep_th_platform = dep_job.task.get('extra', {}).get(
             'treeherder', {}).get('machine', {}).get('platform', '')
         treeherder.setdefault('platform',
                               "{}/opt".format(dep_th_platform))
         treeherder.setdefault('tier', 1)
         treeherder.setdefault('kind', 'build')
 
         label = job['label']
+
+        dependencies = {"repackage": dep_job.label}
+
+        signing_dependencies = dep_job.dependencies
+        # This is so we get the build task etc in our dependencies to
+        # have better beetmover support.
+        dependencies.update({k: v for k, v in signing_dependencies.items()
+                             if k != 'docker-image'})
+
+        locale_str = ""
+        if dep_job.attributes.get('locale'):
+            treeherder['symbol'] = 'rs({})'.format(dep_job.attributes.get('locale'))
+            attributes['locale'] = dep_job.attributes.get('locale')
+            locale_str = "{}/".format(dep_job.attributes.get('locale'))
+
         description = (
             "Signing of repackaged artifacts for locale '{locale}' for build '"
             "{build_platform}/{build_type}'".format(
                 locale=attributes.get('locale', 'en-US'),
                 build_platform=attributes.get('build_platform'),
                 build_type=attributes.get('build_type')
             )
         )
 
-        dependencies = {"repackage": dep_job.label}
-
-        signing_dependencies = dep_job.dependencies
-        # This is so we get the build task etc in our dependencies to
-        # have better beetmover support.
-        dependencies.update({k: v for k, v in signing_dependencies.items()
-                             if k != 'docker-image'})
-        attributes = copy_attributes_from_dependent_job(dep_job)
-        attributes['repackage_type'] = 'repackage-signing'
-
-        locale_str = ""
-        if dep_job.attributes.get('locale'):
-            treeherder['symbol'] = 'rs({})'.format(dep_job.attributes.get('locale'))
-            attributes['locale'] = dep_job.attributes.get('locale')
-            locale_str = "{}/".format(dep_job.attributes.get('locale'))
-
         build_platform = dep_job.attributes.get('build_platform')
         is_nightly = dep_job.attributes.get('nightly')
         signing_cert_scope = get_signing_cert_scope_per_platform(
             build_platform, is_nightly, config
         )
         scopes = [signing_cert_scope, add_scope_prefix(config, 'signing:format:mar_sha384')]
 
         upstream_artifacts = [{