Bug 575218 - More robust check for personal-bookmarks visibility. r=gavin
authorMarco Bonardo <mbonardo@mozilla.com>
Tue, 29 Jun 2010 00:04:01 +0200
changeset 46378 e6055b0ebd2a56cb77d6b7339f44abcef10a1971
parent 46377 fa7b6f39faf46387ef3c1e142a1825e2fd807f59
child 46379 76a73f8537e095e980f6943c2952d870f90e77b1
push id1
push userroot
push dateTue, 26 Apr 2011 22:38:44 +0000
treeherdermozilla-beta@bfdb6e623a36 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgavin
bugs575218
milestone1.9.3a6pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 575218 - More robust check for personal-bookmarks visibility. r=gavin
browser/base/content/browser-places.js
--- a/browser/base/content/browser-places.js
+++ b/browser/base/content/browser-places.js
@@ -1157,17 +1157,17 @@ let BookmarksMenuButton = {
     bookmarksToolbarElt.collapsed =
       this.button.parentNode == this.bookmarksToolbarItem;
   },
 
   updatePosition: function BMB_updatePosition() {
     this._popupNeedsUpdating = true;
 
     let bookmarksToolbarItem = this.bookmarksToolbarItem;
-    if (isElementVisible(bookmarksToolbarItem)) {
+    if (bookmarksToolbarItem && !bookmarksToolbarItem.parentNode.collapsed) {
       if (this.button.parentNode != bookmarksToolbarItem) {
         this.resetView();
         bookmarksToolbarItem.appendChild(this.button);
       }
       this.button.classList.add("bookmark-item");
       this.button.classList.remove("toolbarbutton-1");
     }
     else {