Bug 998377 - Stop nulling out nsInProcessTabChildGlobal::mGlobal during DelayedDisconnect. r=smaug
authorBobby Holley <bobbyholley@gmail.com>
Fri, 18 Apr 2014 16:00:06 -0700
changeset 197826 e5b5eed30c6ec8887c464db72ff1f01ca69d9efd
parent 197810 45a45f4a228fa68e3748735b8c7c02c571ada78d
child 197827 d8c4225f799fbe0a2ae450ecce328a87e95a5155
push id3624
push userasasaki@mozilla.com
push dateMon, 09 Jun 2014 21:49:01 +0000
treeherdermozilla-beta@b1a5da15899a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug
bugs998377
milestone31.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 998377 - Stop nulling out nsInProcessTabChildGlobal::mGlobal during DelayedDisconnect. r=smaug This is already cycle-collected, so no extra work needs to happen.
content/base/src/nsInProcessTabChildGlobal.cpp
--- a/content/base/src/nsInProcessTabChildGlobal.cpp
+++ b/content/base/src/nsInProcessTabChildGlobal.cpp
@@ -232,17 +232,16 @@ nsInProcessTabChildGlobal::DelayedDiscon
     mMessageManager = nullptr;
   }
   if (mListenerManager) {
     mListenerManager->Disconnect();
   }
 
   if (!mLoadingScript) {
     ReleaseWrapper(static_cast<EventTarget*>(this));
-    mGlobal = nullptr;
   } else {
     mDelayedDisconnect = true;
   }
 }
 
 NS_IMETHODIMP_(nsIContent *)
 nsInProcessTabChildGlobal::GetOwnerContent()
 {