Bug 1517730 - Enable the crash reporter by default on Windows/AArch64 builds r=ted
authorGabriele Svelto <gsvelto@mozilla.com>
Wed, 09 Jan 2019 22:39:22 +0000
changeset 510256 e52a03d0cede5f39ad3680e1ac18c72459b744de
parent 510255 c118f7527dc6cb9c5926fd0e81fd14ff3eba0d73
child 510257 6d3266df4764fd0ae813afff1f1a997ab3074224
push id10547
push userffxbld-merge
push dateMon, 21 Jan 2019 13:03:58 +0000
treeherdermozilla-beta@24ec1916bffe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted
bugs1517730
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1517730 - Enable the crash reporter by default on Windows/AArch64 builds r=ted Differential Revision: https://phabricator.services.mozilla.com/D15763
toolkit/crashreporter/nsExceptionHandler.cpp
--- a/toolkit/crashreporter/nsExceptionHandler.cpp
+++ b/toolkit/crashreporter/nsExceptionHandler.cpp
@@ -1393,21 +1393,19 @@ static nsresult LocateExecutable(nsIFile
   return NS_OK;
 }
 
 #endif  // !defined(MOZ_WIDGET_ANDROID)
 
 nsresult SetExceptionHandler(nsIFile* aXREDirectory, bool force /*=false*/) {
   if (gExceptionHandler) return NS_ERROR_ALREADY_INITIALIZED;
 
-#if defined(DEBUG) || defined(_M_ARM64)
+#if defined(DEBUG)
   // In debug builds, disable the crash reporter by default, and allow to
   // enable it with the MOZ_CRASHREPORTER environment variable.
-  // Likewise for Windows arm64 builds, where the crashreporter doesn't
-  // work properly yet.
   const char* envvar = PR_GetEnv("MOZ_CRASHREPORTER");
   if ((!envvar || !*envvar) && !force) return NS_OK;
 #else
   // In other builds, enable the crash reporter by default, and allow
   // disabling it with the MOZ_CRASHREPORTER_DISABLE environment variable.
   const char* envvar = PR_GetEnv("MOZ_CRASHREPORTER_DISABLE");
   if (envvar && *envvar && !force) return NS_OK;
 #endif