Bug 1521599 - Delete the failures data after it has been output. r=Gijs a=lizzard
authorJared Wein <jwein@mozilla.com>
Thu, 31 Jan 2019 23:40:33 +0000
changeset 512997 e4d259ea825ac517f8d2de85430fbd955be2df92
parent 512996 95b884dcbd6f001b990a6353980280050fab9ac6
child 512998 554276c96ebb63cf2e2afc82b4303d78af97b459
push id10673
push userarchaeopteryx@coole-files.de
push dateMon, 11 Feb 2019 18:29:39 +0000
treeherdermozilla-beta@a61f757afab3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs, lizzard
bugs1521599
milestone66.0
Bug 1521599 - Delete the failures data after it has been output. r=Gijs a=lizzard The failures were remaining in the data object, which later had any remaining keys printed in the diagnostics section. This bug was introduced because we stopped using Array objects to generate formatted strings. In the previous code, this would have ended up just printing out the first failure listed in the diagnostics section (a partial duplicate of the actual Failure Log). Differential Revision: https://phabricator.services.mozilla.com/D18289
toolkit/content/aboutSupport.js
--- a/toolkit/content/aboutSupport.js
+++ b/toolkit/content/aboutSupport.js
@@ -392,16 +392,17 @@ var snapshotFormatters = {
         delete data.indices;
       } else {
         $.append($("graphics-failures-tbody"),
           [$.new("tr", [$.new("th", "LogFailure", "column"),
                         $.new("td", data.failures.map(function(val) {
                           return $.new("p", val);
                        }))])]);
       }
+      delete data.failures;
     } else {
       $("graphics-failures-tbody").style.display = "none";
     }
 
     // Add a new row to the table, and take the key (or keys) out of data.
     //
     // @where        Table section to add to.
     // @key          Data key to use.