Bug 1227190. Make the constructor for ReportExceptionClosure explicit to silence our static analyzers. r=CLOSED TREE
☠☠ backed out by 3b3cf9f8e175 ☠ ☠
authorBoris Zbarsky <bzbarsky@mit.edu>
Wed, 02 Dec 2015 14:57:53 -0500
changeset 309459 e3ae43ee51fa19f4ab685e5dfd8d1e051d011566
parent 309458 65f787c9fd4e5ed7013c32f26ae3f6dfcea88bd8
child 309460 d49a71d3b20a24eccdfc7cb194406d21ffb5d085
push id5513
push userraliiev@mozilla.com
push dateMon, 25 Jan 2016 13:55:34 +0000
treeherdermozilla-beta@5ee97dd05b5c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersCLOSED
bugs1227190
milestone45.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1227190. Make the constructor for ReportExceptionClosure explicit to silence our static analyzers. r=CLOSED TREE
js/src/vm/Debugger.cpp
--- a/js/src/vm/Debugger.cpp
+++ b/js/src/vm/Debugger.cpp
@@ -974,17 +974,17 @@ Debugger::unwrapPropertyDescriptor(JSCon
 
     return true;
 }
 
 namespace {
 class MOZ_STACK_CLASS ReportExceptionClosure : public ScriptEnvironmentPreparer::Closure
 {
 public:
-    ReportExceptionClosure(RootedValue& exn)
+    explicit ReportExceptionClosure(RootedValue& exn)
         : exn_(exn)
     {
     }
 
     bool operator()(JSContext* cx) override
     {
         cx->setPendingException(exn_);
         return false;