Bug 1379421: Remove dead code in ServoRestyleManager. r=heycam
authorEmilio Cobos Álvarez <emilio@crisal.io>
Sun, 09 Jul 2017 00:02:16 +0200
changeset 416622 e38da505d63fcc4f1d58df9647f79f6c4c1b1792
parent 416621 3dc1cd7a957c1f919b1c3553a8c8ef59ea8f85f2
child 416623 a3bc7a02a48e0cc517034010cf053fa8684de492
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersheycam
bugs1379421
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1379421: Remove dead code in ServoRestyleManager. r=heycam MozReview-Commit-ID: zNNcy6p5qD
layout/base/ServoRestyleManager.cpp
layout/base/ServoRestyleManager.h
--- a/layout/base/ServoRestyleManager.cpp
+++ b/layout/base/ServoRestyleManager.cpp
@@ -876,50 +876,16 @@ ServoRestyleManager::UpdateOnlyAnimation
   if (!doCSS) {
     return;
   }
 
   DoProcessPendingRestyles(TraversalRestyleBehavior::ForAnimationOnly);
 }
 
 void
-ServoRestyleManager::RestyleForInsertOrChange(nsINode* aContainer,
-                                              nsIContent* aChild)
-{
-  //
-  // XXXbholley: We need the Gecko logic here to correctly restyle for things
-  // like :empty and positional selectors (though we may not need to post
-  // restyle events as agressively as the Gecko path does).
-  //
-  // Bug 1297899 tracks this work.
-  //
-}
-
-void
-ServoRestyleManager::RestyleForAppend(nsIContent* aContainer,
-                                      nsIContent* aFirstNewContent)
-{
-  //
-  // XXXbholley: We need the Gecko logic here to correctly restyle for things
-  // like :empty and positional selectors (though we may not need to post
-  // restyle events as agressively as the Gecko path does).
-  //
-  // Bug 1297899 tracks this work.
-  //
-}
-
-void
-ServoRestyleManager::ContentRemoved(nsINode* aContainer,
-                                    nsIContent* aOldChild,
-                                    nsIContent* aFollowingSibling)
-{
-  NS_WARNING("stylo: ServoRestyleManager::ContentRemoved not implemented");
-}
-
-void
 ServoRestyleManager::ContentStateChanged(nsIContent* aContent,
                                          EventStates aChangedBits)
 {
   MOZ_ASSERT(!mInStyleRefresh);
 
   if (!aContent->IsElement()) {
     return;
   }
--- a/layout/base/ServoRestyleManager.h
+++ b/layout/base/ServoRestyleManager.h
@@ -120,27 +120,16 @@ public:
   void RebuildAllStyleData(nsChangeHint aExtraHint,
                            nsRestyleHint aRestyleHint);
   void PostRebuildAllStyleDataEvent(nsChangeHint aExtraHint,
                                     nsRestyleHint aRestyleHint);
   void ProcessPendingRestyles();
 
   void UpdateOnlyAnimationStyles();
 
-  void ContentInserted(nsINode* aContainer, nsIContent* aChild);
-  void ContentAppended(nsIContent* aContainer,
-                       nsIContent* aFirstNewContent);
-  void ContentRemoved(nsINode* aContainer,
-                      nsIContent* aOldChild,
-                      nsIContent* aFollowingSibling);
-
-  void RestyleForInsertOrChange(nsINode* aContainer,
-                                nsIContent* aChild);
-  void RestyleForAppend(nsIContent* aContainer,
-                        nsIContent* aFirstNewContent);
   void ContentStateChanged(nsIContent* aContent, EventStates aStateMask);
   void AttributeWillChange(dom::Element* aElement,
                            int32_t aNameSpaceID,
                            nsIAtom* aAttribute,
                            int32_t aModType,
                            const nsAttrValue* aNewValue);
   void ClassAttributeWillBeChangedBySMIL(dom::Element* aElement);