Backed out changeset 1b93ec532890 (bug 1367110)
authorSebastian Hengst <archaeopteryx@coole-files.de>
Wed, 31 May 2017 21:02:11 +0200
changeset 409726 e30c63dcb366d2e8f89751d3962a9cbe50e58a2e
parent 409725 83f02ddde71f96da055af41fd10c945be89dde67
child 409727 1941e33040491f2ba9c435cf10747e9200901083
push id7391
push usermtabara@mozilla.com
push dateMon, 12 Jun 2017 13:08:53 +0000
treeherdermozilla-beta@2191d7f87e2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1367110
milestone55.0a1
backs out1b93ec532890d3e4d88c730634339a9cfdd4000b
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 1b93ec532890 (bug 1367110)
dom/webidl/XMLHttpRequest.webidl
dom/xhr/XMLHttpRequest.h
dom/xhr/XMLHttpRequestMainThread.h
dom/xhr/XMLHttpRequestWorker.h
--- a/dom/webidl/XMLHttpRequest.webidl
+++ b/dom/webidl/XMLHttpRequest.webidl
@@ -150,16 +150,11 @@ interface XMLHttpRequest : XMLHttpReques
   attribute ByteString? networkInterfaceId;
 
   [Throws, ChromeOnly, Exposed=Window]
   any getInterface(IID iid);
 
   [ChromeOnly, Exposed=Window]
   void setOriginAttributes(optional OriginAttributesDictionary originAttributes);
 
-  // Only works on MainThread.
-  // Its permanence is to be evaluated in bug 1368540 for Firefox 60.
-  [ChromeOnly]
-  readonly attribute unsigned short errorCode;
-
   readonly attribute boolean mozAnon;
   readonly attribute boolean mozSystem;
 };
--- a/dom/xhr/XMLHttpRequest.h
+++ b/dom/xhr/XMLHttpRequest.h
@@ -163,19 +163,16 @@ public:
   virtual void
   GetInterface(JSContext* aCx, nsIJSID* aIID,
                JS::MutableHandle<JS::Value> aRetval,
                ErrorResult& aRv) = 0;
 
   virtual void
   SetOriginAttributes(const mozilla::dom::OriginAttributesDictionary& aAttrs) = 0;
 
-  virtual uint16_t
-  ErrorCode() const = 0;
-
   virtual bool
   MozAnon() const = 0;
 
   virtual bool
   MozSystem() const = 0;
 
   virtual JSObject*
   WrapObject(JSContext *aCx, JS::Handle<JSObject*> aGivenProto) override
--- a/dom/xhr/XMLHttpRequestMainThread.h
+++ b/dom/xhr/XMLHttpRequestMainThread.h
@@ -474,22 +474,16 @@ public:
   GetResponseXML(ErrorResult& aRv) override;
 
   virtual bool
   MozBackgroundRequest() const override;
 
   virtual void
   SetMozBackgroundRequest(bool aMozBackgroundRequest, ErrorResult& aRv) override;
 
-  virtual uint16_t
-  ErrorCode() const override
-  {
-    return static_cast<uint16_t>(mErrorLoad);
-  }
-
   virtual bool
   MozAnon() const override;
 
   virtual bool
   MozSystem() const override;
 
   virtual nsIChannel*
   GetChannel() const override
--- a/dom/xhr/XMLHttpRequestWorker.h
+++ b/dom/xhr/XMLHttpRequestWorker.h
@@ -280,21 +280,16 @@ public:
 
   void
   NullResponseText()
   {
     mStateData.mResponseText.SetVoid();
     mStateData.mResponse.setNull();
   }
 
-  virtual uint16_t ErrorCode() const override
-  {
-    return 0; // eOK
-  }
-
   virtual bool MozAnon() const override
   {
     return mMozAnon;
   }
 
   virtual bool MozSystem() const override
   {
     return mMozSystem;