Bug 1579430 - mark some elfhack methods as `override`; r=glandium
authorNathan Froyd <froydnj@mozilla.com>
Mon, 09 Sep 2019 23:54:34 +0000
changeset 553752 e302a2dfc55b5cd44961ab7e55d549205a3c6d1c
parent 553751 3519c255f86ede2d7ebf06ac9df7dd29a1a3eeea
child 553753 2bdd2503fbdb0408ceb2c46a07311543a123c950
push id12169
push userffxbld-merge
push dateMon, 14 Oct 2019 16:59:29 +0000
treeherdermozilla-beta@c819687300ed [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1579430
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1579430 - mark some elfhack methods as `override`; r=glandium This change silences a couple of clang warnings. Differential Revision: https://phabricator.services.mozilla.com/D45007
build/unix/elfhack/elfhack.cpp
--- a/build/unix/elfhack/elfhack.cpp
+++ b/build/unix/elfhack/elfhack.cpp
@@ -189,17 +189,17 @@ class ElfRelHackCode_Section : public El
       memcpy(buf, (*c)->getData(), (*c)->getSize());
       buf += (*c)->getSize();
     }
     name = elfhack_text;
   }
 
   ~ElfRelHackCode_Section() { delete elf; }
 
-  void serialize(std::ofstream& file, char ei_class, char ei_data) {
+  void serialize(std::ofstream& file, char ei_class, char ei_data) override {
     // Readjust code offsets
     for (std::vector<ElfSection*>::iterator c = code.begin(); c != code.end();
          ++c)
       (*c)->getShdr().sh_addr += getAddr();
 
     // Apply relocations
     for (std::vector<ElfSection*>::iterator c = code.begin(); c != code.end();
          ++c) {
@@ -212,17 +212,17 @@ class ElfRelHackCode_Section : public El
           else
             apply_relocations((ElfRel_Section<Elf_Rela>*)rel, *c);
         }
     }
 
     ElfSection::serialize(file, ei_class, ei_data);
   }
 
-  bool isRelocatable() { return false; }
+  bool isRelocatable() override { return false; }
 
   unsigned int getEntryPoint() { return entry_point; }
 
   void insertBefore(ElfSection* section, bool dirty = true) override {
     // Adjust the address so that this section is adjacent to the one it's
     // being inserted before. This avoids creating holes which subsequently
     // might lead the PHDR-adjusting code to create unnecessary additional
     // PT_LOADs.