Backed out 2 changesets (bug 1367621) for breaking the next test, browser_newtab_perwindow_private_browsing.js, on OS X
authorPhil Ringnalda <philringnalda@gmail.com>
Fri, 26 May 2017 19:29:27 -0700
changeset 409039 e2f55539f966bcb2b5379115dc1afa7705e67bfb
parent 409038 a8ec7813e32144756ba1ca0455c8794812490e02
child 409040 a18aea273eefbb9e80a9499d2045c56d99214b8b
push id7391
push usermtabara@mozilla.com
push dateMon, 12 Jun 2017 13:08:53 +0000
treeherdermozilla-beta@2191d7f87e2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1367621
milestone55.0a1
backs outfedfdd4d63bca78ddcf13a6f981a0be7c5cd4ad7
92cd7b48120b239b2dc1de845cd278fbc724a9ac
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out 2 changesets (bug 1367621) for breaking the next test, browser_newtab_perwindow_private_browsing.js, on OS X CLOSED TREE Backed out changeset fedfdd4d63bc (bug 1367621) Backed out changeset 92cd7b48120b (bug 1367621) MozReview-Commit-ID: E1kuaL830LG
browser/base/content/tabbrowser.xml
browser/base/content/test/newtab/browser.ini
browser/base/content/test/newtab/browser_newtab_fullscreen_focus.js
--- a/browser/base/content/tabbrowser.xml
+++ b/browser/base/content/tabbrowser.xml
@@ -1340,17 +1340,17 @@
           // If the user happened to type into the URL bar for this browser
           // by the time we got here, focusing will cause the text to be
           // selected which could cause them to overwrite what they've
           // already typed in.
           if (gURLBar.focused && newBrowser.userTypedValue) {
             return;
           }
 
-          if (!window.fullScreen || isTabEmpty(newTab)) {
+          if (!window.fullScreen || isTabEmpty(this.mCurrentTab)) {
             focusAndSelectUrlBar();
             return;
           }
         }
 
         // Focus the find bar if it was previously focused for that tab.
         if (gFindBarInitialized && !gFindBar.hidden &&
             this.selectedTab._findBarFocused) {
--- a/browser/base/content/test/newtab/browser.ini
+++ b/browser/base/content/test/newtab/browser.ini
@@ -23,17 +23,16 @@ skip-if = (os == "mac" && debug) # tempo
 [browser_newtab_bug1271075.js]
 [browser_newtab_disable.js]
 [browser_newtab_drag_drop.js]
 [browser_newtab_drag_drop_ext.js]
 # temporary until determine why more intermittent on VM
 subsuite = clipboard
 [browser_newtab_drop_preview.js]
 [browser_newtab_focus.js]
-[browser_newtab_fullscreen_focus.js]
 [browser_newtab_perwindow_private_browsing.js]
 [browser_newtab_reflow_load.js]
 support-files =
   content-reflows.js
 [browser_newtab_search.js]
 support-files =
   searchEngineNoLogo.xml
   searchEngineFavicon.xml
deleted file mode 100644
--- a/browser/base/content/test/newtab/browser_newtab_fullscreen_focus.js
+++ /dev/null
@@ -1,33 +0,0 @@
-"use strict";
-
-/**
- * Checks that the URL bar is correctly focused
- * when a new tab is opened while in fullscreen
- * mode.
- */
-add_task(async function() {
-  gURLBar.blur();
-
-  Assert.ok(!window.fullScreen, "Should not start in fullscreen mode.");
-
-  let enterFs = BrowserTestUtils.waitForEvent(window, "fullscreen");
-  BrowserFullScreen();
-  await enterFs;
-
-  registerCleanupFunction(async function() {
-    // Exit fullscreen if we're still in it.
-    if (window.fullScreen) {
-      let exitFs = BrowserTestUtils.waitForEvent(window, "fullscreen");
-      BrowserFullScreen();
-      await exitFs;
-    }
-  });
-
-  Assert.ok(window.fullScreen, "Should be in fullscreen mode now.");
-
-  let newTabOpened = BrowserTestUtils.waitForEvent(gBrowser, "TabSwitchDone");
-  BrowserOpenTab();
-  await newTabOpened;
-
-  Assert.ok(gURLBar.focused, "URL bar should be focused.");
-});