Bug 1533558 - Delete dead _formFillService code in LoginManager.jsm r=MattN
authornidhi <nimbus2020b@gmail.com>
Tue, 12 Mar 2019 20:29:23 +0000
changeset 521644 e2cb9629e540
parent 521643 fcaf6f3d0497
child 521645 c1e2b7779d6a
push id10867
push userdvarga@mozilla.com
push dateThu, 14 Mar 2019 15:20:45 +0000
treeherdermozilla-beta@abad13547875 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersMattN
bugs1533558
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1533558 - Delete dead _formFillService code in LoginManager.jsm r=MattN Differential Revision: https://phabricator.services.mozilla.com/D23212
toolkit/components/passwordmgr/LoginManager.jsm
--- a/toolkit/components/passwordmgr/LoginManager.jsm
+++ b/toolkit/components/passwordmgr/LoginManager.jsm
@@ -52,25 +52,16 @@ LoginManager.prototype = {
 
     throw new Components.Exception("Interface not available", Cr.NS_ERROR_NO_INTERFACE);
   },
 
 
   /* ---------- private members ---------- */
 
 
-  __formFillService: null, // FormFillController, for username autocompleting
-  get _formFillService() {
-    if (!this.__formFillService) {
-      this.__formFillService = Cc["@mozilla.org/satchel/form-fill-controller;1"].
-                               getService(Ci.nsIFormFillController);
-    }
-    return this.__formFillService;
-  },
-
 
   _storage: null, // Storage component which contains the saved logins
   _prefBranch: null, // Preferences service
   _remember: true,  // mirrors signon.rememberSignons preference
 
 
   /**
    * Initialize the Login Manager. Automatically called when service
@@ -133,17 +124,16 @@ LoginManager.prototype = {
 
         if (prefName == "rememberSignons") {
           this._pwmgr._remember =
               this._pwmgr._prefBranch.getBoolPref("rememberSignons");
         } else {
           log.debug("Oops! Pref not handled, change ignored.");
         }
       } else if (topic == "xpcom-shutdown") {
-        delete this._pwmgr.__formFillService;
         delete this._pwmgr._storage;
         delete this._pwmgr._prefBranch;
         this._pwmgr = null;
       } else if (topic == "passwordmgr-storage-replace") {
         (async () => {
           await this._pwmgr._storage.terminate();
           this._pwmgr._initStorage();
           await this._pwmgr.initializationPromise;