Bug 1507844 - Push the devtools.inspector.flexboxHighlighter.enabled pref in browser_markup_display_node[01/02].js; r=pbro
authorGabriel Luong <gabriel.luong@gmail.com>
Tue, 20 Nov 2018 12:16:10 -0500
changeset 503766 e25e40a58667cc86d17fa52aa3704e42c598243e
parent 503765 637291128b2e0f395d52b5c7565681e00d115976
child 503767 6ce084069f3883f3c4d6e7d912f591891b2399e7
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspbro
bugs1507844
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1507844 - Push the devtools.inspector.flexboxHighlighter.enabled pref in browser_markup_display_node[01/02].js; r=pbro
devtools/client/inspector/markup/test/browser_markup_display_node_01.js
devtools/client/inspector/markup/test/browser_markup_display_node_02.js
--- a/devtools/client/inspector/markup/test/browser_markup_display_node_01.js
+++ b/devtools/client/inspector/markup/test/browser_markup_display_node_01.js
@@ -28,16 +28,18 @@ const TEST_URI = `
   <div id="flex">Flex</div>
   <div id="block">Block</div>
   <span>HELLO WORLD</span>
 `;
 
 add_task(async function() {
   info("Enable subgrid in order to see the subgrid display type.");
   await pushPref("layout.css.grid-template-subgrid-value.enabled", true);
+  info("Enable the flexbox highlighter to get the interactive flex display badge.");
+  await pushPref("devtools.inspector.flexboxHighlighter.enabled", true);
 
   const {inspector} = await openInspectorForURL("data:text/html;charset=utf-8," +
     encodeURIComponent(TEST_URI));
 
   info("Check the display node is shown and the value of #grid.");
   await selectNode("#grid", inspector);
   const gridContainer = await getContainerForSelector("#grid", inspector);
   const gridDisplayNode = gridContainer.elt.querySelector(
--- a/devtools/client/inspector/markup/test/browser_markup_display_node_02.js
+++ b/devtools/client/inspector/markup/test/browser_markup_display_node_02.js
@@ -93,16 +93,19 @@ const TEST_DATA = [
     after: {
       textContent: "flex",
       visible: true,
     },
   },
 ];
 
 add_task(async function() {
+  info("Enable the flexbox highlighter to get the interactive flex display badge.");
+  await pushPref("devtools.inspector.flexboxHighlighter.enabled", true);
+
   const {inspector, testActor} = await openInspectorForURL(
     "data:text/html;charset=utf-8," + encodeURIComponent(TEST_URI));
 
   for (const data of TEST_DATA) {
     info("Running test case: " + data.desc);
     await runTestData(inspector, testActor, data);
   }
 });