Bug 1394785 - ignore unstable osx gtest r=jmaher
authorIonut Goldan <ionut.goldan@softvision.ro>
Wed, 06 Sep 2017 10:47:40 +0300
changeset 428657 e00a0a13c7fa19ef4aac8627cf2046991b663cc2
parent 428656 cd25a0a7bccae993b29436de5224e3fde81018f7
child 428658 f366810cead49fe9a2a812ee0441c2bff66b7a49
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher
bugs1394785
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1394785 - ignore unstable osx gtest r=jmaher MozReview-Commit-ID: L1dZJpDL9Ir
netwerk/test/gtest/TestStandardURL.cpp
--- a/netwerk/test/gtest/TestStandardURL.cpp
+++ b/netwerk/test/gtest/TestStandardURL.cpp
@@ -211,24 +211,27 @@ MOZ_GTEST_BENCH(TestStandardURL, Normali
       ASSERT_EQ(NS_OK, Test_NormalizeIPv4(encHost3, result));
       nsAutoCString encHost4("111.159.123.220");
       ASSERT_EQ(NS_OK, Test_NormalizeIPv4(encHost4, result));
       nsAutoCString encHost5("1.160.204.200");
       ASSERT_EQ(NS_OK, Test_NormalizeIPv4(encHost5, result));
     }
 });
 
+// Bug 1394785 - ignore unstable test on OSX
+#ifndef XP_MACOSX
 // Note the five calls in the loop, so divide by 100k
 MOZ_GTEST_BENCH(TestStandardURL, NormalizePerfFails, [] {
     nsAutoCString result;
     for (int i = 0; i < 20000; i++) {
       nsAutoCString encHost("123.292.12.32");
       ASSERT_EQ(NS_ERROR_FAILURE, Test_NormalizeIPv4(encHost, result));
       nsAutoCString encHost2("83.62.12.0x13292");
       ASSERT_EQ(NS_ERROR_FAILURE, Test_NormalizeIPv4(encHost2, result));
       nsAutoCString encHost3("8.7.6.0xhello");
       ASSERT_EQ(NS_ERROR_FAILURE, Test_NormalizeIPv4(encHost3, result));
       nsAutoCString encHost4("111.159.notonmywatch.220");
       ASSERT_EQ(NS_ERROR_FAILURE, Test_NormalizeIPv4(encHost4, result));
       nsAutoCString encHost5("1.160.204.20f");
       ASSERT_EQ(NS_ERROR_FAILURE, Test_NormalizeIPv4(encHost5, result));
     }
 });
+#endif