Bug 1352113 - Shippable Builds - Don't use enable-full-crashsymbols attribute when we explicitly disable symbols for a job. r=aki
authorJustin Wood <Callek@gmail.com>
Wed, 27 Mar 2019 13:45:53 +0000
changeset 525184 dfcd5e5299f75611f2710079b2608a10299e1308
parent 525183 1de2be687d8fc0e76e9dc08ccec7a73d2bc4a0a2
child 525185 d2cfbde267e9e953c90d72fd66e0b0e12f775851
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaki
bugs1352113
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1352113 - Shippable Builds - Don't use enable-full-crashsymbols attribute when we explicitly disable symbols for a job. r=aki Differential Revision: https://phabricator.services.mozilla.com/D24999
taskcluster/taskgraph/transforms/build.py
--- a/taskcluster/taskgraph/transforms/build.py
+++ b/taskcluster/taskgraph/transforms/build.py
@@ -130,16 +130,17 @@ def enable_full_crashsymbols(config, job
     branches = RELEASE_PROJECTS | {'try', }
     for job in jobs:
         enable_full_crashsymbols = job['attributes'].get('enable-full-crashsymbols')
         if enable_full_crashsymbols and config.params['project'] in branches:
             logger.debug("Enabling full symbol generation for %s", job['name'])
         else:
             logger.debug("Disabling full symbol generation for %s", job['name'])
             job['worker']['env']['MOZ_DISABLE_FULL_SYMBOLS'] = '1'
+            job['attributes'].pop('enable-full-crashsymbols', None)
         yield job
 
 
 @transforms.add
 def use_artifact(config, jobs):
     if config.params['try_mode'] == 'try_task_config':
         use_artifact = config.params['try_task_config'] \
             .get('templates', {}).get('artifact', {}).get('enabled')