Bug 1516275 - Allow users to close RDM on first click even when tooltip is visible; r=jdescottes
authorRazvan Caliman <rcaliman@mozilla.com>
Wed, 09 Jan 2019 10:32:05 +0000
changeset 510125 ded030d641a2fd955e72236a39e8df127694193a
parent 510124 00d33e7058c1261b31ddd3b8df31e39c98212c3e
child 510126 5b5648fde79119e3d4f9dc68b1bbc3714dd1e8a2
push id10547
push userffxbld-merge
push dateMon, 21 Jan 2019 13:03:58 +0000
treeherdermozilla-beta@24ec1916bffe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjdescottes
bugs1516275
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1516275 - Allow users to close RDM on first click even when tooltip is visible; r=jdescottes Setup RDM tooltip to not consume clicks and allow users to interact with the RDM on first try. The behavior of consuming clicks led at least one user to believe RDM could not be closed and filed a bug. Likely others encountered the same (small) road block when trying other actions. Differential Revision: https://phabricator.services.mozilla.com/D15943
devtools/client/responsive.html/setting-onboarding-tooltip.js
--- a/devtools/client/responsive.html/setting-onboarding-tooltip.js
+++ b/devtools/client/responsive.html/setting-onboarding-tooltip.js
@@ -15,17 +15,20 @@ const CONTAINER_WIDTH = 270;
 
 /**
  * Setting onboarding tooltip that is shown on the setting menu button in the RDM toolbar
  * when the pref is on.
  */
 class SettingOnboardingTooltip {
   constructor(doc) {
     this.doc = doc;
-    this.tooltip = new HTMLTooltip(this.doc, { type: "arrow" });
+    this.tooltip = new HTMLTooltip(this.doc, {
+      consumeOutsideClicks: false,
+      type: "arrow",
+    });
 
     this.onCloseButtonClick = this.onCloseButtonClick.bind(this);
 
     const container = doc.createElement("div");
     container.className = "onboarding-container";
 
     const icon = doc.createElement("span");
     icon.className = "onboarding-icon";