Bug 1517575 - Change nsIUpdate and nsIUpdatePatch attributes that can be read only to read only. r=mhowell
authorRobert Strong <robert.bugzilla@gmail.com>
Wed, 09 Jan 2019 08:24:35 -0800
changeset 510197 de454ec382003d9b2d1f229fbacf215e068808cb
parent 510196 1c36dba855691e0525a736fac6f93d9afb679abb
child 510198 eec2f1188f37b7bd2433e24c8c5edd7fbb5381ab
push id10547
push userffxbld-merge
push dateMon, 21 Jan 2019 13:03:58 +0000
treeherdermozilla-beta@24ec1916bffe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmhowell
bugs1517575
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1517575 - Change nsIUpdate and nsIUpdatePatch attributes that can be read only to read only. r=mhowell
toolkit/mozapps/update/nsIUpdateService.idl
--- a/toolkit/mozapps/update/nsIUpdateService.idl
+++ b/toolkit/mozapps/update/nsIUpdateService.idl
@@ -23,32 +23,32 @@ webidl Document;
 interface nsIUpdatePatch : nsISupports
 {
   /**
    * The type of this patch:
    * "partial"      A binary difference between two application versions
    * "complete"     A complete patch containing all of the replacement files
    *                to update to the new version
    */
-  attribute AString type;
+  readonly attribute AString type;
 
   /**
    * The URL this patch was being downloaded from
    */
-  attribute AString URL;
+  readonly attribute AString URL;
 
   /**
    * The final URL this patch was being downloaded from
    */
   attribute AString finalURL;
 
   /**
    * The size of this file, in bytes.
    */
-  attribute unsigned long size;
+  readonly attribute unsigned long size;
 
   /**
    * The state of this patch
    */
   attribute AString state;
 
   /**
    * A numeric error code that conveys additional information about the state of
@@ -87,69 +87,69 @@ interface nsIUpdatePatch : nsISupports
 [scriptable, uuid(e094c045-f4ff-41fd-92da-cd2effd2c7c9)]
 interface nsIUpdate : nsISupports
 {
   /**
    * The type of update:
    *   "major"  A major new version of the Application
    *   "minor"  A minor update to the Application (e.g. security update)
    */
-  attribute AString type;
+  readonly attribute AString type;
 
   /**
    * The name of the update, or "<Application Name> <Update Version>"
    */
-  attribute AString name;
+  readonly attribute AString name;
 
   /**
    * The string to display in the user interface for the version. If you want
    * a real version number use appVersion.
    */
-  attribute AString displayVersion;
+  readonly attribute AString displayVersion;
 
   /**
    * The Application version of this update.
    */
-  attribute AString appVersion;
+  readonly attribute AString appVersion;
 
   /**
    * The Application version prior to the application being updated.
    */
-  attribute AString previousAppVersion;
+  readonly attribute AString previousAppVersion;
 
   /**
    * The Build ID of this update. Used to determine a particular build, down
    * to the hour, minute and second of its creation. This allows the system
    * to differentiate between several nightly builds with the same |version|
    * for example.
    */
-  attribute AString buildID;
+  readonly attribute AString buildID;
 
   /**
    * The URL to a page which offers details about the content of this
    * update. Ideally, this page is not the release notes but some other page
    * that summarizes the differences between this update and the previous,
    * which also links to the release notes.
    */
-  attribute AString detailsURL;
+  readonly attribute AString detailsURL;
 
   /**
    * The URL to the Update Service that supplied this update.
    */
-  attribute AString serviceURL;
+  readonly attribute AString serviceURL;
 
   /**
    * The channel used to retrieve this update from the Update Service.
    */
-  attribute AString channel;
+  readonly attribute AString channel;
 
   /**
    * Whether the update is no longer supported on this system.
    */
-  attribute boolean unsupported;
+  readonly attribute boolean unsupported;
   
   /**
    * Allows overriding the default amount of time in seconds before prompting the
    * user to apply an update. If not specified, the value of
    * app.update.promptWaitTime will be used.
    */
   attribute long long promptWaitTime;