Bug 1551218 - Part 2: Remove devtools debugger eslint rules conflicting with any prettier configuration, r=Standard8,jlast
authorVictor Porof <vporof@mozilla.com>
Fri, 17 May 2019 15:50:53 +0000
changeset 533175 de264ab1edfb54409ebbdd184b54a058ef7faa4f
parent 533174 edafe8d51cbf5f1585db25785ef204936777392e
child 533176 88358b362c57617c0c18926a8ead7337efe9c86a
push id11276
push userrgurzau@mozilla.com
push dateMon, 20 May 2019 13:11:24 +0000
treeherdermozilla-beta@847755a7c325 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersStandard8, jlast
bugs1551218
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1551218 - Part 2: Remove devtools debugger eslint rules conflicting with any prettier configuration, r=Standard8,jlast Differential Revision: https://phabricator.services.mozilla.com/D30927
devtools/client/debugger/.eslintrc
--- a/devtools/client/debugger/.eslintrc
+++ b/devtools/client/debugger/.eslintrc
@@ -78,33 +78,27 @@
       }
     ],
 
     // Check for import errors.
     "import/no-duplicates": "error",
     "import/named": "error",
     "import/export": "error",
 
-    // Enforce the spacing around the * in generator functions.
-    "generator-star-spacing": [2, "after"],
-
     "flowtype/define-flow-type": 1,
     "flowtype/use-flow-type": 1,
 
     // Disallow flow control that escapes from "finally".
     "no-unsafe-finally": "error",
 
     // Disallow using variables outside the blocks they are defined (especially
     // since only let and const are used, see "no-var").
     "block-scoped-var": 2,
     // Require camel case names
     "camelcase": 2,
-    // Allow trailing commas for easy list extension.  Having them does not
-    // impair readability, but also not required either.
-    "comma-dangle": 0,
     // Warn about cyclomatic complexity in functions.
     "complexity": ["error", { "max": 22 }],
     // Don't warn for inconsistent naming when capturing this (not so important
     // with auto-binding fat arrow functions).
     "consistent-this": 0,
     // Enforce curly brace conventions for all control statements.
     "curly": 2,
     // Don't require a default case in switch statements. Avoid being forced to
@@ -119,36 +113,22 @@
     // This makes the code more verbose and hard to read. Our engine already
     // does a fantastic job assigning a name to the function, which includes
     // the enclosing function name, and worst case you have a line number that
     // you can just look up.
     "func-names": 0,
     // Allow use of function declarations and expressions.
     "func-style": 0,
     // Deprecated, will be removed in 1.0.
-    "generator-star": 0,
-    // Deprecated, will be removed in 1.0.
     "global-strict": 0,
     // Only useful in a node environment.
     "handle-callback-err": 0,
-    // Allow mixed 'LF' and 'CRLF' as linebreaks.
-    "linebreak-style": 0,
     // Don't enforce the maximum depth that blocks can be nested. The complexity
     // rule is a better rule to check this.
     "max-depth": 0,
-    // Maximum length of a line.
-    "max-len": [
-      2,
-      80,
-      2,
-      {
-        "ignoreUrls": true,
-        "ignorePattern": "\\s*require\\s*\\(|^\\s*loader\\.lazy|-\\*-"
-      }
-    ],
     // Maximum depth callbacks can be nested.
     "max-nested-callbacks": [2, 4],
     // Don't limit the number of parameters that can be used in a function.
     "max-params": 0,
     // Don't limit the maximum number of statement allowed in a function. We
     // already have the complexity rule that's a better measurement.
     "max-statements": 0,
     // Require a capital letter for constructors, only check if all new
@@ -159,18 +139,16 @@
     "no-array-constructor": 2,
     // Allow use of bitwise operators.
     "no-bitwise": 0,
     // Disallow use of arguments.caller or arguments.callee.
     "no-caller": 2,
     // Disallow the catch clause parameter name being the same as a variable in
     // the outer scope, to avoid confusion.
     "no-catch-shadow": 2,
-    // Deprecated, will be removed in 1.0.
-    "no-comma-dangle": 0,
     // Disallow assignment in conditional expressions.
     "no-cond-assign": 2,
     // Allow using the console API.
     "no-console": 0,
     // Allow using constant expressions in conditions like while (true)
     "no-constant-condition": 0,
     // Allow use of the continue statement.
     "no-continue": 0,
@@ -207,24 +185,20 @@
     // Disallow assigning to the exception in a catch block.
     "no-ex-assign": 2,
     // Disallow adding to native types
     "no-extend-native": 2,
     // Disallow unnecessary function binding.
     "no-extra-bind": 2,
     // Disallow double-negation boolean casts in a boolean context.
     "no-extra-boolean-cast": 2,
-    // Allow unnecessary parentheses, as they may make the code more readable.
-    "no-extra-parens": 0,
     // Deprecated, will be removed in 1.0.
     "no-extra-strict": 0,
     // Disallow fallthrough of case statements, except if there is a comment.
     "no-fallthrough": 2,
-    // Allow the use of leading or trailing decimal points in numeric literals.
-    "no-floating-decimal": 0,
     // Disallow comments inline after code.
     "no-inline-comments": 2,
     // Disallow if as the only statement in an else block.
     "no-lonely-if": 2,
     // Allow mixing regular variable and require declarations (not a node env).
     "no-mixed-requires": 0,
     // Disallow use of multiline strings (use template strings instead).
     "no-multi-str": 2,
@@ -255,18 +229,16 @@
     // Allow using process.exit (not a node environment).
     "no-process-exit": 0,
     // Disallow usage of __proto__ property.
     "no-proto": 2,
     // Disallow declaring the same variable more than once (we use let anyway).
     "no-redeclare": 2,
     // Disallow multiple spaces in a regular expression literal.
     "no-regex-spaces": 2,
-    // Allow reserved words being used as object literal keys.
-    "no-reserved-keys": 0,
     // Don't restrict usage of specified node modules (not a node environment).
     "no-restricted-modules": 0,
     // Disallow use of assignment in return statement. It is preferable for a
     // single line of code to have only one easily predictable effect.
     "no-return-assign": 2,
     // Allow use of javascript: urls.
     "no-script-url": 0,
     // Disallow comparisons where both sides are exactly the same.
@@ -276,18 +248,16 @@
     // Warn about declaration of variables already declared in the outer scope.
     // This isn't an error because it sometimes is useful to use the same name
     // in a small helper function rather than having to come up with another
     // random name.
     // Still, making this a warning can help people avoid being confused.
     "no-shadow": 2,
     // Disallow shadowing of names such as arguments.
     "no-shadow-restricted-names": 2,
-    // Deprecated, will be removed in 1.0.
-    "no-space-before-semi": 0,
     // Disallow sparse arrays, eg. let arr = [,,2].
     // Array destructuring is fine though:
     // for (let [, breakpointPromise] of aPromises)
     "no-sparse-arrays": 2,
     // Allow use of synchronous methods (not a node environment).
     "no-sync": 0,
     // Allow the use of ternary operators.
     "no-ternary": 0,
@@ -319,59 +289,36 @@
     // Disallow use of the with statement.
     "no-with": 2,
     // Dont require method and property shorthand syntax for object literals.
     // We use this in the code a lot, but not consistently, and this seems more
     // like something to check at code review time.
     "object-shorthand": 0,
     // Allow more than one variable declaration per function.
     "one-var": 0,
-    // Disallow padding within blocks.
-    //"padded-blocks": [2, "never"],
-    // Dont require quotes around object literal property names.
-    "quote-props": 0,
-    // Double quotes should be used.
-    "quotes": [2, "double", "avoid-escape"],
     // Require use of the second argument for parseInt().
     "radix": 2,
     // Dont require to sort variables within the same declaration block.
     // Anyway, one-var is disabled.
     "sort-vars": 0,
-    // Deprecated, will be removed in 1.0.
-    "space-after-function-name": 0,
-    // Deprecated, will be removed in 1.0.
-    "space-before-function-parentheses": 0,
-    // Disallow space before function opening parenthesis.
-    //"space-before-function-paren": [2, "never"],
-    // Disable the rule that checks if spaces inside {} and [] are there or not.
-    // Our code is split on conventions, and itd be nice to have 2 rules
-    // instead, one for [] and one for {}. So, disabling until we write them.
-    "space-in-brackets": 0,
-    // Deprecated, will be removed in 1.0.
-    "space-unary-word-ops": 0,
     // Require a space immediately following the // in a line comment.
     "spaced-comment": [2, "always"],
     // Require "use strict" to be defined globally in the script.
     "strict": [2, "global"],
     // Disallow comparisons with the value NaN.
     "use-isnan": 2,
     // Warn about invalid JSDoc comments.
     // Disabled for now because of https://github.com/eslint/eslint/issues/2270
     // The rule fails on some jsdoc comments like in:
     // devtools/client/webconsole/console-output.js
     "valid-jsdoc": 0,
     // Ensure that the results of typeof are compared against a valid string.
     "valid-typeof": 2,
     // Allow vars to be declared anywhere in the scope.
     "vars-on-top": 0,
-    // Dont require immediate function invocation to be wrapped in parentheses.
-    "wrap-iife": 0,
-    // Don't require regex literals to be wrapped in parentheses (which
-    // supposedly prevent them from being mistaken for division operators).
-    "wrap-regex": 0,
     // Disallow Yoda conditions (where literal value comes first).
     "yoda": 2,
 
     // And these are the rules that haven't been discussed so far, and that are
     // disabled for now until we introduce them, one at a time.
 
     // Require for-in loops to have an if statement.
     "guard-for-in": 0,
@@ -417,23 +364,19 @@
     // var foo = "Copyright \251";
     "no-octal-escape": 0,
     // disallow use of undefined when initializing variables
     "no-undef-init": 0,
     // disallow usage of expressions in statement position
     "no-unused-expressions": 0,
     // disallow use of void operator
     "no-void": 0,
-    // disallow wrapping of non-IIFE statements in parens
-    "no-wrap-func": 0,
     // require assignment operator shorthand where possible or prohibit it
     // entirely
     "operator-assignment": 0,
-    // enforce operators to be placed before or after line breaks
-    "operator-linebreak": 0,
 
     // Rules from the prettier plugin
     "prettier/prettier": "error",
 
     "file-header/file-header": [
       "error",
       [
         "This Source Code Form is subject to the terms of the Mozilla Public",