Bug 1496297 - Use |jit-test| skip-if as appropriate in jit-test/tests/xdr/ (r=jorendorff)
authorEric Faust <efausbmo@gmail.com>
Tue, 09 Oct 2018 15:41:50 -0700
changeset 496135 de0ab3ea1796c48872614041a6e87b34073a184a
parent 496134 222b9bd838ecc373b3e09442ca285ebca215ef2c
child 496136 179b81691182a23085d1bd73931e4d86842677f8
push id9984
push userffxbld-merge
push dateMon, 15 Oct 2018 21:07:35 +0000
treeherdermozilla-beta@183d27ea8570 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjorendorff
bugs1496297
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1496297 - Use |jit-test| skip-if as appropriate in jit-test/tests/xdr/ (r=jorendorff)
js/src/jit-test/tests/xdr/bug1390856.js
js/src/jit-test/tests/xdr/decode-off-thread.js
--- a/js/src/jit-test/tests/xdr/bug1390856.js
+++ b/js/src/jit-test/tests/xdr/bug1390856.js
@@ -1,14 +1,9 @@
-if (!('oomTest' in this))
-    quit();
-
-if (helperThreadCount() == 0)
-    quit();
-
+// |jit-test| skip-if: !('oomTest' in this) || helperThreadCount() === 0
 
 let THREAD_TYPE_PARSE = 4;
 
 // Test main thread encode/decode OOM
 oomTest(function() {
     let t = cacheEntry(`function f() { function g() { }; return 3; };`);
 
     evaluate(t, { sourceIsLazy: true, saveIncrementalBytecode: true });
--- a/js/src/jit-test/tests/xdr/decode-off-thread.js
+++ b/js/src/jit-test/tests/xdr/decode-off-thread.js
@@ -1,10 +1,9 @@
-if (helperThreadCount() == 0)
-  quit();
+// |jit-test| skip-if: helperThreadCount() === 0
 
 function evalWithCacheLoadOffThread(code, ctx) {
   ctx = ctx || {};
   ctx = Object.create(ctx, {
     fileName: { value: "evalWithCacheCode.js" },
     lineNumber: { value: 0 }
   });
   code = code instanceof Object ? code : cacheEntry(code);