Bug 1296128 - Indicate permission panel's 'X' button while focus. r=dao, a=ritu
authorRicky Chien <ricky060709@gmail.com>
Tue, 23 Aug 2016 21:25:14 +0800
changeset 348023 ddd6e3e541f1e406dca4a51fb257e68d3c968644
parent 348022 87fdc70ec48b8e83b4051f75584d890729cbc7c8
child 348024 11228436d644eaa50c2dbfb840e309c61d2bef02
push id6389
push userraliiev@mozilla.com
push dateMon, 19 Sep 2016 13:38:22 +0000
treeherdermozilla-beta@01d67bfe6c81 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao, ritu
bugs1296128
milestone50.0a2
Bug 1296128 - Indicate permission panel's 'X' button while focus. r=dao, a=ritu MozReview-Commit-ID: 8MqXkLpJoKU
browser/themes/osx/controlcenter/panel.css
browser/themes/shared/controlcenter/panel.inc.css
--- a/browser/themes/osx/controlcenter/panel.css
+++ b/browser/themes/osx/controlcenter/panel.css
@@ -12,16 +12,20 @@
 .identity-popup-expander:-moz-focusring {
   padding: 2px;
 }
 
 .identity-popup-expander:-moz-focusring > .button-box {
   @hudButtonFocused@
 }
 
+.identity-popup-permission-remove-button:-moz-focusring {
+  box-shadow: @focusRingShadow@;
+}
+
 #identity-popup-multiView > .panel-viewcontainer > .panel-viewstack > .panel-subviews {
   border-bottom-right-radius: 3.5px;
 }
 
 #identity-popup-multiView > .panel-viewcontainer > .panel-viewstack > .panel-subviews:-moz-locale-dir(rtl) {
   border-bottom-right-radius: 0;
   border-bottom-left-radius: 3.5px;
 }
--- a/browser/themes/shared/controlcenter/panel.inc.css
+++ b/browser/themes/shared/controlcenter/panel.inc.css
@@ -394,36 +394,36 @@ description#identity-popup-content-verif
   border-width: 0;
   border-radius: 50%;
   min-width: 0;
   padding: 2px;
   background-color: transparent;
 }
 
 .identity-popup-permission-remove-button > .button-box {
-  border-width: 0;
   padding: 0;
+  -moz-appearance: none;
 }
 
 .identity-popup-permission-remove-button > .button-box > .button-icon {
   margin: 0;
   width: 16px;
   height: 16px;
   list-style-image: url(chrome://browser/skin/panel-icons.svg#cancel);
   filter: url(chrome://browser/skin/filters.svg#fill);
   fill: #999;
 }
 
 .identity-popup-permission-remove-button > .button-box > .button-text {
   display: none;
 }
 
-.identity-popup-permission-remove-button:hover {
+.identity-popup-permission-remove-button:not(:-moz-focusring):hover {
   background-color: #999;
 }
 
-.identity-popup-permission-remove-button:hover > .button-box > .button-icon {
+.identity-popup-permission-remove-button:not(:-moz-focusring):hover > .button-box > .button-icon {
   fill: #fff;
 }
 
-.identity-popup-permission-remove-button:hover:active {
+.identity-popup-permission-remove-button:not(:-moz-focusring):hover:active {
   background-color: #808080;
 }