Try backing out bug 792689 because it's the only non-merge cset in the MaxHeap regression range for both m-i and m-c.
authorKyle Huey <khuey@kylehuey.com>
Thu, 20 Sep 2012 12:42:13 -0700
changeset 113959 dd72607cee2f5cc820f71aeedd9976b2af8943df
parent 113958 b68455ccdd9a5b87035b71a64a653e307fb5b372
child 113960 8d579bf6e2de0c14846365e8e702080ae9ce4acf
push id1708
push userakeybl@mozilla.com
push dateMon, 19 Nov 2012 21:10:21 +0000
treeherdermozilla-beta@27b14fe50103 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs792689
milestone18.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Try backing out bug 792689 because it's the only non-merge cset in the MaxHeap regression range for both m-i and m-c.
mfbt/Likely.h
--- a/mfbt/Likely.h
+++ b/mfbt/Likely.h
@@ -7,16 +7,16 @@
  * MOZ_LIKELY and MOZ_UNLIKELY macros to hint to the compiler how a
  * boolean predicate should be branch-predicted.
  */
 
 #ifndef mozilla_Likely_h_
 #define mozilla_Likely_h_
 
 #if defined(__clang__) || (defined(__GNUC__) && (__GNUC__ > 2))
-#  define MOZ_LIKELY(x)   (__builtin_expect(!!(x), 1))
-#  define MOZ_UNLIKELY(x) (__builtin_expect(!!(x), 0))
+#  define MOZ_LIKELY(x)   (__builtin_expect((x), 1))
+#  define MOZ_UNLIKELY(x) (__builtin_expect((x), 0))
 #else
-#  define MOZ_LIKELY(x)   (!!(x))
-#  define MOZ_UNLIKELY(x) (!!(x))
+#  define MOZ_LIKELY(x)   (x)
+#  define MOZ_UNLIKELY(x) (x)
 #endif
 
 #endif /* mozilla_Likely_h_ */