Bug 1395920 - Remove vertical dividers in tabs tray page. r=nechen
authorJing-wei Wu <topwu.tw@gmail.com>
Tue, 05 Sep 2017 11:23:50 +0800
changeset 428379 dd6a6ffa8d22ff349af8f8ec6018924b9867c2b1
parent 428378 9aa2e9106aa353198a228d32186c4a9cddfdcb21
child 428380 e18c8795f0d9a7e1496ce31d521a7b0d825db806
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnechen
bugs1395920
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1395920 - Remove vertical dividers in tabs tray page. r=nechen MozReview-Commit-ID: HZQcuSLbuOm
mobile/android/app/src/main/res/drawable-hdpi/tab_indicator_divider.9.png
mobile/android/app/src/main/res/drawable-xhdpi/tab_indicator_divider.9.png
mobile/android/app/src/main/res/layout/tabs_panel_default.xml
mobile/android/app/src/photon/res/values/dimens.xml
deleted file mode 100644
index f1338d8031ce95bd4ee12befcf44868e3ce293dd..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100644
index f1338d8031ce95bd4ee12befcf44868e3ce293dd..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
--- a/mobile/android/app/src/main/res/layout/tabs_panel_default.xml
+++ b/mobile/android/app/src/main/res/layout/tabs_panel_default.xml
@@ -32,18 +32,16 @@
                 android:src="@drawable/tabs_panel_nav_back"
                 android:contentDescription="@string/back"
                 android:background="@drawable/action_bar_button_inverse"/>
 
             <org.mozilla.gecko.widget.IconTabWidget android:id="@+id/tab_widget"
                                                     android:layout_width="wrap_content"
                                                     android:layout_height="match_parent"
                                                     android:tabStripEnabled="false"
-                                                    android:divider="@drawable/tab_indicator_divider"
-                                                    android:dividerPadding="@dimen/tab_panel_divider_vertical_padding"
                                                     android:layout="@layout/tabs_panel_indicator"/>
 
             <View android:layout_width="0dip"
                   android:layout_height="match_parent"
                   android:layout_weight="1.0"/>
 
             <ImageButton android:id="@+id/add_tab"
                          style="@style/UrlBar.ImageButton"
--- a/mobile/android/app/src/photon/res/values/dimens.xml
+++ b/mobile/android/app/src/photon/res/values/dimens.xml
@@ -42,20 +42,16 @@
     <!-- If you update one of these values, update the others. -->
     <dimen name="tablet_nav_button_width">48dp</dimen>
     <dimen name="tablet_nav_button_width_half">21dp</dimen>
     <dimen name="tablet_nav_button_width_plus_half">36dp</dimen>
 
     <dimen name="tablet_fwd_button_padding_start">4dp</dimen>
     <dimen name="tablet_fwd_button_padding_end">4dp</dimen>
 
-    <!-- This is the system default for the vertical padding for the divider of the TabWidget.
-         Used to mimic the divider padding on the tablet tabs panel back button. -->
-    <dimen name="tab_panel_divider_vertical_padding">12dp</dimen>
-
     <dimen name="tablet_tab_strip_height">48dp</dimen>
     <dimen name="tablet_tab_strip_item_width">178dp</dimen>
     <dimen name="tablet_tab_strip_item_height">40dp</dimen>
     <dimen name="tablet_tab_strip_fading_edge_size">15dp</dimen>
     <dimen name="tablet_tab_strip_item_margin">0dp</dimen>
     <dimen name="tablet_tab_strip_divider_width">1dp</dimen>
     <dimen name="tablet_tab_strip_divider_height">30dp</dimen>
     <dimen name="tablet_tab_strip_divider_padding_bottom">4dp</dimen>