Bug 1130203 - Review: Finish off share overlay nits. r=trivial a=sylvestre
authorMichael Comella <michael.l.comella@gmail.com>
Mon, 23 Mar 2015 11:28:56 -0700
changeset 258353 dcadb3572692
parent 258352 ce7199dbb0af
child 258354 994526939c21
push id4648
push usermichael.l.comella@gmail.com
push date2015-04-08 16:26 +0000
treeherdermozilla-beta@e399294c9df3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstrivial, sylvestre
bugs1130203
milestone38.0
Bug 1130203 - Review: Finish off share overlay nits. r=trivial a=sylvestre Changes include code alignment and clarifying comments.
mobile/android/base/resources/layout/overlay_share_dialog.xml
mobile/android/base/resources/layout/overlay_share_send_tab_item.xml
--- a/mobile/android/base/resources/layout/overlay_share_dialog.xml
+++ b/mobile/android/base/resources/layout/overlay_share_dialog.xml
@@ -39,17 +39,17 @@
             style="@style/ShareOverlayTitle"
             android:textAppearance="@style/ShareOverlayTextAppearance.Header"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_marginBottom="20dp"
             android:textSize="12sp"
             android:scrollHorizontally="true"/>
 
-        <!-- TODO: Add back drop shadow? -->
+        <!-- TODO: Add back drop shadow (bug 1146488)? -->
         <!-- Buttons -->
         <!-- "Send to Firefox Sync" -->
         <org.mozilla.gecko.overlays.ui.SendTabList
             android:id="@+id/overlay_send_tab_btn"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:orientation="vertical"
             android:divider="@null"/>
--- a/mobile/android/base/resources/layout/overlay_share_send_tab_item.xml
+++ b/mobile/android/base/resources/layout/overlay_share_send_tab_item.xml
@@ -1,9 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
 
 <!-- The first item's background is unique and these views are reused
      so the background is set dynamically. -->
-<org.mozilla.gecko.overlays.ui.OverlayDialogButton xmlns:android="http://schemas.android.com/apk/res/android"
+<org.mozilla.gecko.overlays.ui.OverlayDialogButton
+    xmlns:android="http://schemas.android.com/apk/res/android"
     style="@style/ShareOverlayRow"
     android:id="@+id/overlay_send_tab_item"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"/>