Bug 1275538: P1. Abort early if a skip request is in progress. r=gerald,kamidphish
authorJean-Yves Avenard <jyavenard@mozilla.com>
Thu, 26 May 2016 13:59:46 +1000
changeset 338328 dc73bf8a692f2f11ef182f4ab1967b08d272a42c
parent 338327 3098ba832e42bb289a3951c5b7a9b3147b59aab5
child 338329 d3428c4506b5669b181160b869dbf027cf60e473
push id6249
push userjlund@mozilla.com
push dateMon, 01 Aug 2016 13:59:36 +0000
treeherdermozilla-beta@bad9d4f5bf7e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgerald, kamidphish
bugs1275538
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1275538: P1. Abort early if a skip request is in progress. r=gerald,kamidphish We would only abort early if new data had been received. Which may not always be the case. MozReview-Commit-ID: HvAUq5CTc7F
dom/media/MediaFormatReader.cpp
--- a/dom/media/MediaFormatReader.cpp
+++ b/dom/media/MediaFormatReader.cpp
@@ -1099,16 +1099,21 @@ MediaFormatReader::Update(TrackType aTra
   bool needOutput = false;
   auto& decoder = GetDecoderData(aTrack);
   decoder.mUpdateScheduled = false;
 
   if (!mInitDone) {
     return;
   }
 
+  if (aTrack == TrackType::kVideoTrack && mSkipRequest.Exists()) {
+    LOGV("Skipping in progress, nothing more to do");
+    return;
+  }
+
   if (UpdateReceivedNewData(aTrack)) {
     LOGV("Nothing more to do");
     return;
   }
 
   if (decoder.mSeekRequest.Exists()) {
     LOGV("Seeking hasn't completed, nothing more to do");
     return;