Bug 1530571 - Explicitly specify animation_value_type for scroll-padding. r=boris
authorHiroyuki Ikezoe <hikezoe@mozilla.com>
Tue, 26 Feb 2019 10:17:25 +0000
changeset 518937 dc54c909289c55fbbee1e620cfd56fe65b4c406f
parent 518936 6f9ea704602d4d9ea63afe2627bb3812d851373d
child 518938 8f991ed45f905ec8a7d576665cd7c1a7c0ec6fe7
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersboris
bugs1530571
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1530571 - Explicitly specify animation_value_type for scroll-padding. r=boris Otherwise the Trait for clamping negative animation value isn't generated thus negative animating results are exposed in computed values. Depends on D21152 Differential Revision: https://phabricator.services.mozilla.com/D21153
servo/components/style/properties/longhands/padding.mako.rs
--- a/servo/components/style/properties/longhands/padding.mako.rs
+++ b/servo/components/style/properties/longhands/padding.mako.rs
@@ -34,11 +34,11 @@
         "scroll-padding-%s" % side[0],
         "NonNegativeLengthPercentageOrAuto",
         "computed::NonNegativeLengthPercentageOrAuto::auto()",
         products="gecko",
         gecko_pref="layout.css.scroll-snap-v1.enabled",
         logical=side[1],
         logical_group="scroll-padding",
         spec="https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-padding-%s" % side[0],
-        animation_value_type="ComputedValue",
+        animation_value_type="NonNegativeLengthPercentageOrAuto",
     )}
 % endfor