Backed out changeset 3096a547bb84 (bug 1546546) for Cpp failures in TestDllInterceptor.exe. CLOSED TREE
authorDorel Luca <dluca@mozilla.com>
Fri, 26 Apr 2019 00:52:11 +0300
changeset 530187 dbb622ba7d3766027749787461f69b8cd23acde8
parent 530186 a8eca5bd4f5bfe01d3df76d0ddb4fa255e4333ff
child 530188 d9e0ffa11ce7837c9dffbdeab702a37a50c9857f
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1546546
milestone68.0a1
backs out3096a547bb84ea6bdf0f543b36591e920c90ae51
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 3096a547bb84 (bug 1546546) for Cpp failures in TestDllInterceptor.exe. CLOSED TREE
mozglue/misc/interceptor/VMSharingPolicies.h
--- a/mozglue/misc/interceptor/VMSharingPolicies.h
+++ b/mozglue/misc/interceptor/VMSharingPolicies.h
@@ -100,19 +100,18 @@ class VMSharingPolicyShared<MMPolicyInPr
   }
 
   operator const MMPolicyInProcess&() const {
     AutoCriticalSection lock(&sCS);
     return sUniqueVM;
   }
 
   bool ShouldUnhookUponDestruction() const {
-    // Unhooking on destruction has issues with static destructor order.
-    // See bug 1546546.
-    return false;
+    AutoCriticalSection lock(&sCS);
+    return sUniqueVM.ShouldUnhookUponDestruction();
   }
 
   bool Reserve(uint32_t aCount, const ReservationFlags aFlags) {
     AutoCriticalSection lock(&sCS);
     return sUniqueVM.Reserve(aCount, aFlags);
   }
 
   bool IsPageAccessible(void* aVAddress) const {