Bug 1278644 - Remove CombinedHistoryPanel dependency to fix bustage. r=grisha, a=sledru
authorGrigory Kruglov <gkruglov@mozilla.com>
Mon, 25 Jul 2016 08:07:54 -0700
changeset 340113 db67e1188e8dd1d3a798d1bb9dae43c8a5e41abc
parent 340112 e3d202c9c23067c2e3f18ee0d53a32ba98d4bcea
child 340114 2edcaa7c3912be834b21fb185196500adf571ed2
push id6249
push userjlund@mozilla.com
push dateMon, 01 Aug 2016 13:59:36 +0000
treeherdermozilla-beta@bad9d4f5bf7e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgrisha, sledru
bugs1278644
milestone49.0a2
Bug 1278644 - Remove CombinedHistoryPanel dependency to fix bustage. r=grisha, a=sledru MozReview-Commit-ID: GGtXuGDnqwb
mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryAdapter.java
--- a/mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryAdapter.java
+++ b/mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryAdapter.java
@@ -170,22 +170,19 @@ public class CombinedHistoryAdapter exte
      */
     @Override
     public long getItemId(int position) {
         // Two randomly selected large primes used to generate non-clashing IDs.
         final long PRIME_BOOKMARKS = 32416189867L;
         final long PRIME_SECTION_HEADERS = 32416187737L;
 
         // RecyclerView.NO_ID is -1, so let's start from -2 for our hard-coded IDs.
-        final int RECENT_TABS_ID = -2;
-        final int SYNCED_DEVICES_ID = -3;
+        final int SYNCED_DEVICES_ID = -2;
 
         switch (getItemTypeForPosition(position)) {
-            case RECENT_TABS:
-                return RECENT_TABS_ID;
             case SYNCED_DEVICES:
                 return SYNCED_DEVICES_ID;
             case SECTION_HEADER:
                 // We might have multiple section headers, so we try get unique IDs for them.
                 return position * PRIME_SECTION_HEADERS;
             case HISTORY:
                 if (!historyCursor.moveToPosition(position)) {
                     return RecyclerView.NO_ID;